Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes a bug in MatrixStepper when sharding queries. #3550

Merged
merged 4 commits into from
Mar 29, 2021
Merged

Fixes a bug in MatrixStepper when sharding queries. #3550

merged 4 commits into from
Mar 29, 2021

Commits on Mar 26, 2021

  1. Fixes a bug in MatrixStepper when sharding queries. 

    Since we split correctly metric queries, this bug has show itself.
Basically we were not correctly stepping through time. We should always start from start, add the step until the start is after the end.

For more read: https://www.robustperception.io/step-and-query_range

Fixes grafana#3541

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
    @cyriltovena
    cyriltovena committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    30dc2d6 View commit details
    Browse the repository at this point in the history

  2. Fixes tests. 

    Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
    @cyriltovena
    cyriltovena committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    12225d8 View commit details
    Browse the repository at this point in the history

  3. Fixes tests. for real. 

    Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
    @cyriltovena
    cyriltovena committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    fd3de13 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2021

  1. Not easy to get those test working. 

    Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
    @cyriltovena
    cyriltovena committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    ce7c13d View commit details
    Browse the repository at this point in the history