Query Filtering -- Querier #5482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Get deletes from the index gateway and attach them to store and ingester requests
| for _, del := range d { | ||
| for _, selector := range del.Selectors { | ||
| if int64(del.StartTime) <= end && int64(del.EndTime) >= start { | ||
| deletes = append(deletes, &logproto.Delete{ |
There was a problem hiding this comment.
In a future PR it would be nice to have this as a metrics somewhere so we can see if the different instances are in sync.
|
This relies on #5481, converting to a draft PR so I can make the necessary changes when it's merged |
owen-d
reviewed
Mar 7, 2022
|
There's nothing technically stopping it. I think it's going to conflict with #5481 quite a bit, though. |
|
@owen-d I proposed some some changes to the API PR above and I don't think it's going to interfere with this PR much at all. I think we're good to review/merge |
owen-d
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first PR for query filtering for deletes. It adds a delete store to the querier. The querier uses that to lookup any delete request for the current user, finds the ones that overlap with the query range, and forwards them to downstream ingesters and stores.
This is implemented for both Logs and Metrics.