-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query Filtering -- Querier #5482
Query Filtering -- Querier #5482
Conversation
- Get deletes from the index gateway and attach them to store and ingester requests
for _, del := range d { | ||
for _, selector := range del.Selectors { | ||
if int64(del.StartTime) <= end && int64(del.EndTime) >= start { | ||
deletes = append(deletes, &logproto.Delete{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In a future PR it would be nice to have this as a metrics somewhere so we can see if the different instances are in sync.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This relies on #5481, converting to a draft PR so I can make the necessary changes when it's merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking really good. When are you planning to remove draft
?
There's nothing technically stopping it. I think it's going to conflict with #5481 quite a bit, though. |
@owen-d I proposed some some changes to the API PR above and I don't think it's going to interfere with this PR much at all. I think we're good to review/merge |
This is the first PR for query filtering for deletes. It adds a delete store to the querier. The querier uses that to lookup any delete request for the current user, finds the ones that overlap with the query range, and forwards them to downstream ingesters and stores.
This is implemented for both Logs and Metrics.