-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query Filtering -- Querier #5482
Merged
owen-d
merged 7 commits into
grafana:main
from
MasslessParticle:tpatterson/querier-delete-filter
Mar 14, 2022
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
3466250
Query Filtering -- Querier
MasslessParticle 66b5e0b
lint
MasslessParticle d31a3bd
Fix test -- sometimes svc is nil
MasslessParticle 5401fff
Merge branch 'main' into tpatterson/querier-delete-filter
MasslessParticle 296080a
don't test for delete overlap on each selector
MasslessParticle 0081fee
lint
MasslessParticle 8a0d297
Merge branch 'main' into tpatterson/querier-delete-filter
MasslessParticle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
package loki | ||
|
||
import ( | ||
"github.com/grafana/dskit/services" | ||
|
||
"github.com/grafana/loki/pkg/storage/stores/shipper/compactor/deletion" | ||
) | ||
|
||
func deleteRequestsStoreListener(d deletion.DeleteRequestsStore) *listener { | ||
return &listener{d} | ||
} | ||
|
||
type listener struct { | ||
deleteRequestsStore deletion.DeleteRequestsStore | ||
} | ||
|
||
// Starting is called when the service transitions from NEW to STARTING. | ||
func (l *listener) Starting() {} | ||
|
||
// Running is called when the service transitions from STARTING to RUNNING. | ||
func (l *listener) Running() {} | ||
|
||
// Stopping is called when the service transitions to the STOPPING state. | ||
func (l *listener) Stopping(from services.State) { | ||
if from == services.Stopping || from == services.Terminated || from == services.Failed { | ||
// no need to do anything | ||
return | ||
} | ||
l.deleteRequestsStore.Stop() | ||
} | ||
|
||
// Terminated is called when the service transitions to the TERMINATED state. | ||
func (l *listener) Terminated(from services.State) { | ||
if from == services.Stopping || from == services.Terminated || from == services.Failed { | ||
// no need to do anything | ||
return | ||
} | ||
l.deleteRequestsStore.Stop() | ||
} | ||
|
||
// Failed is called when the service transitions to the FAILED state. | ||
func (l *listener) Failed(from services.State, failure error) { | ||
if from == services.Stopping || from == services.Terminated || from == services.Failed { | ||
// no need to do anything | ||
return | ||
} | ||
l.deleteRequestsStore.Stop() | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In a future PR it would be nice to have this as a metrics somewhere so we can see if the different instances are in sync.