Docs: Add changelog entry for configuration parameter name change #6340
Conversation
CHANGELOG.md
Outdated
| @@ -81,6 +81,7 @@ | |||
| * [5685](https://github.com/grafana/loki/pull/5685) **chaudum**: Assert that push values tuples consist of string values | |||
| ##### Changes | |||
| * [6042](https://github.com/grafana/loki/pull/6042) **slim-bean**: Add a new configuration to allow fudging of ingested timestamps to guarantee sort order of duplicate timestamps at query time. | |||
| * [6120](https://github.com/grafana/loki/pull/6120) **KMiller-Grafana**: Rename the fudging of ingested timestamps configuration parameter introduced in PR 6042 to avoid using the slang term "fudge." | |||
There was a problem hiding this comment.
I think just saying the change will be more pleasing to end-users. In case they'd like to understand the reasoning behind the change they can always look for the PR description.
| * [6120](https://github.com/grafana/loki/pull/6120) **KMiller-Grafana**: Rename the fudging of ingested timestamps configuration parameter introduced in PR 6042 to avoid using the slang term "fudge." | |
| * [6120](https://github.com/grafana/loki/pull/6120) **KMiller-Grafana**: Rename fudge_duplicate_timestamp parameter to increment_duplicate_timestamp" |
|
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0%
+ distributor 0%
+ querier 0%
+ querier/queryrange 0.1%
+ iter 0%
+ storage 0%
+ chunkenc 0%
+ logql 0%
+ loki 0% |
|
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0%
- distributor -0.3%
+ querier 0%
+ querier/queryrange 0%
+ iter 0%
+ storage 0%
+ chunkenc 0%
+ logql 0%
+ loki 0% |
PR #6120 renamed a configuration parameter. I forgot to include a changelog entry with that PR. This PR adds that changelog entry.