Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Add changelog entry for configuration parameter name change #6340

Merged
merged 2 commits into from
Jun 8, 2022
Merged

Docs: Add changelog entry for configuration parameter name change #6340

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a733b1
Docs: Add changelog entry for configuration parameter name change
KMiller-Grafana Jun 8, 2022
00bb55c
Update changelog message, per review request
KMiller-Grafana Jun 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@
* [5685](https://github.com/grafana/loki/pull/5685) **chaudum**: Assert that push values tuples consist of string values
##### Changes
* [6042](https://github.com/grafana/loki/pull/6042) **slim-bean**: Add a new configuration to allow fudging of ingested timestamps to guarantee sort order of duplicate timestamps at query time.
* [6120](https://github.com/grafana/loki/pull/6120) **KMiller-Grafana**: Rename the fudging of ingested timestamps configuration parameter introduced in PR 6042 to avoid using the slang term "fudge."
Copy link
Contributor

@DylanGuedes DylanGuedes Jun 8, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just saying the change will be more pleasing to end-users. In case they'd like to understand the reasoning behind the change they can always look for the PR description.

Suggested change
* [6120](https://github.com/grafana/loki/pull/6120) **KMiller-Grafana**: Rename the fudging of ingested timestamps configuration parameter introduced in PR 6042 to avoid using the slang term "fudge."
* [6120](https://github.com/grafana/loki/pull/6120) **KMiller-Grafana**: Rename fudge_duplicate_timestamp parameter to increment_duplicate_timestamp"

* [5777](https://github.com/grafana/loki/pull/5777) **tatchiuleung**: storage: make Azure blobID chunk delimiter configurable
* [5650](https://github.com/grafana/loki/pull/5650) **cyriltovena**: Remove more chunkstore and schema version below v9
* [5643](https://github.com/grafana/loki/pull/5643) **simonswine**: Introduce a ChunkRef type as part of logproto
Expand Down