-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable TLS MinVersion and CipherSuites #7227
Conversation
ec22964
to
7285226
Compare
7285226
to
91068bf
Compare
f45a8db
to
c654116
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
c654116
to
3ccbb58
Compare
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0%
+ distributor 0%
+ querier 0%
+ querier/queryrange 0%
+ iter 0%
+ storage 0%
+ chunkenc 0%
+ logql 0%
+ loki 0% |
@@ -118,6 +118,7 @@ func New(cfg Config, limits Limits, log log.Logger, registerer prometheus.Regist | |||
} | |||
|
|||
func (f *Frontend) starting(ctx context.Context) error { | |||
f.subservicesWatcher = services.NewFailureWatcher() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this change in Frontend
relate to the rest of the PR which is about TLS settings?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this in order to pass the test cases.
This change had to be made as a result of update weaveworks/common
. In the newer version (which contained the TLS properties), an error/panic to occur when invoking the function without a watcher.
What this PR does / why we need it:
This PR updates the
weaveworks/common
andgrafana/dskit
libraries so that theCipherSuites
andMinVersion
fields incrypto/tls
can be set for the various Loki components.Which issue(s) this PR fixes:
Special notes for your reviewer:
Dependent on:
Checklist
CONTRIBUTING.md
guideCHANGELOG.md
updateddocs/sources/upgrading/_index.md