Configurable TLS MinVersion and CipherSuites #7227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type/docs
Red-GV
changed the title
periklis
reviewed
Sep 22, 2022
Red-GV
force-pushed
the
tls-config-update
branch
from
ec22964
to
7285226
Compare
Red-GV
force-pushed
the
tls-config-update
branch
from
7285226
to
91068bf
Compare
Red-GV
force-pushed
the
tls-config-update
branch
from
f45a8db
to
c654116
Compare
Red-GV
force-pushed
the
tls-config-update
branch
from
c654116
to
3ccbb58
Compare
|
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0%
+ distributor 0%
+ querier 0%
+ querier/queryrange 0%
+ iter 0%
+ storage 0%
+ chunkenc 0%
+ logql 0%
+ loki 0% |
periklis
approved these changes
Sep 29, 2022
5 tasks
5 tasks
bboreham
reviewed
Oct 18, 2022
| @@ -118,6 +118,7 @@ func New(cfg Config, limits Limits, log log.Logger, registerer prometheus.Regist | |||
| } | |||
|
|
|||
| func (f *Frontend) starting(ctx context.Context) error { | |||
| f.subservicesWatcher = services.NewFailureWatcher() | |||
There was a problem hiding this comment.
How does this change in Frontend relate to the rest of the PR which is about TLS settings?
There was a problem hiding this comment.
I added this in order to pass the test cases.
This change had to be made as a result of update weaveworks/common. In the newer version (which contained the TLS properties), an error/panic to occur when invoking the function without a watcher.
lxwzy
pushed a commit
to lxwzy/loki
that referenced
this pull request
Nov 7, 2022
changhyuni
pushed a commit
to changhyuni/loki
that referenced
this pull request
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR updates the
weaveworks/commonandgrafana/dskitlibraries so that theCipherSuitesandMinVersionfields incrypto/tlscan be set for the various Loki components.Which issue(s) this PR fixes:
Special notes for your reviewer:
Dependent on:
Checklist
CONTRIBUTING.mdguideCHANGELOG.mdupdateddocs/sources/upgrading/_index.md