operator: Move Loki operand from v2.6.1 to main-ec0bf70 #7298
Conversation
|
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0%
+ distributor 0%
+ querier 0%
+ querier/queryrange 0%
+ iter 0%
+ storage 0%
+ chunkenc 0%
+ logql 0%
+ loki 0% |
periklis
force-pushed
the
use-loki-main-image
branch
from
9758b70
to
aa32886
Compare
|
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0%
+ distributor 0%
+ querier 0%
+ querier/queryrange 0%
+ iter 0%
+ storage 0%
+ chunkenc 0%
+ logql 0%
+ loki 0% |
periklis
force-pushed
the
use-loki-main-image
branch
from
aa32886
to
abe527e
Compare
|
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0%
+ distributor 0%
+ querier 0%
+ querier/queryrange 0.1%
+ iter 0%
+ storage 0%
+ chunkenc 0%
+ logql 0%
+ loki 0% |
There was a problem hiding this comment.
Sorry, did not spot the wrong port in the first pass. Already tested with the changed port, but it does not work with the changed port out of the box as well, because it can not verify the CA certificate. Seems like the clients to the compactor also need the other TLS options if TLS is enabled.
Example error:
loki-querier ts=2022-10-04T09:46:26.347308744Z caller=spanlogger.go:80 user=application level=error msg="failed loading deletes for user" err="Get \"https://lokistack-dev-compactor-http.openshift-logging.svc.cluster.local:3100/loki/api/v1/delete\": x509: certificate signed by unknown authority"
| @@ -79,6 +79,11 @@ func ConfigOptions(opt Options) config.Options { | |||
| Stack: opt.Stack, | |||
| Namespace: opt.Namespace, | |||
| Name: opt.Name, | |||
| Compactor: config.Address{ | |||
| FQDN: fqdn(NewCompactorHTTPService(opt).GetName(), opt.Namespace), | |||
| Port: grpcPort, | |||
There was a problem hiding this comment.
Sorry, I did not spot this the first time.
| Port: grpcPort, | |
| Port: httpPort, |
periklis
force-pushed
the
use-loki-main-image
branch
from
abe527e
to
d091d0b
Compare
|
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0%
+ distributor 0%
+ querier 0%
+ querier/queryrange 0%
+ iter 0%
+ storage 0%
+ chunkenc 0%
+ logql 0.4%
+ loki 0% |
There was a problem hiding this comment.
Giving the compactor client the necessary TLS configuration needs a change in Loki. We decided to go ahead with this change anyway, even with the error logged, as this change is for unblocking other features and we are currently not using the deletion-endpoint of the compactor.
What this PR does / why we need it:
Upgrade the operand Loki from v2.6.1 temporarily to
main-ec0bf70to include 2.7.0 targeted features for the operator development:Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguideCHANGELOG.mdupdateddocs/sources/upgrading/_index.md