Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openshift-loki] Add config for branch upstream-v2.7.0-pre-ec0bf70 #32827

Conversation

periklis
Copy link
Contributor

@periklis periklis commented Oct 4, 2022

The Loki-Operator is moving for target release release-5.6 (currently main) towards Loki v2.7.0 (release pending). To unblock a series of Loki Operator PRs the following configuration adds upstream CI support for a branch that represents a pre-release of Loki v2.7.0 at upstream commit grafana/loki@ec0bf70.

Required for:

/cc @xperimental

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2022
Copy link
Contributor

@xperimental xperimental left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine for me, just one optional comment. Did a very quick pass only, so it makes sense that someone else also has a look ...

@periklis periklis force-pushed the loki-upstream-v2.7.0-pre-ec0bf70 branch from 5c6f8b3 to 5a861ed Compare October 4, 2022 11:32
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 4, 2022

@periklis: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Red-GV
Copy link
Contributor

Red-GV commented Oct 4, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: periklis, Red-GV

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 9302663 into openshift:master Oct 4, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 4, 2022

@periklis: Updated the following 2 configmaps:

  • ci-operator-misc-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-loki-upstream-v2.7.0-pre-ec0bf70.yaml using file ci-operator/config/openshift/loki/openshift-loki-upstream-v2.7.0-pre-ec0bf70.yaml
  • job-config-misc configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-loki-upstream-v2.7.0-pre-ec0bf70-postsubmits.yaml using file ci-operator/jobs/openshift/loki/openshift-loki-upstream-v2.7.0-pre-ec0bf70-postsubmits.yaml
    • key openshift-loki-upstream-v2.7.0-pre-ec0bf70-presubmits.yaml using file ci-operator/jobs/openshift/loki/openshift-loki-upstream-v2.7.0-pre-ec0bf70-presubmits.yaml

In response to this:

The Loki-Operator is moving for target release release-5.6 (currently main) towards Loki v2.7.0 (release pending). To unblock a series of Loki Operator PRs the following configuration adds upstream CI support for a branch that represents a pre-release of Loki v2.7.0 at upstream commit grafana/loki@ec0bf70.

Required for:

/cc @xperimental

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants