Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update _index.md #9331

Merged
merged 1 commit into from
May 3, 2023
Merged

Update _index.md #9331

merged 1 commit into from
May 3, 2023

Conversation

MattiasSegerdahl
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/upgrading/_index.md

@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Apr 27, 2023
kavirajk
kavirajk approved these changes May 1, 2023
View reviewed changes
Copy link
Contributor

@kavirajk kavirajk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! will wait for @JStickler review before merging.

@GrafanaWriter GrafanaWriter removed the Q1SE label May 2, 2023
JStickler
JStickler approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[docs team] LGTM

@jeschkies jeschkies merged commit 233e525 into main May 3, 2023
@jeschkies jeschkies deleted the MattiasSegerdahl-fluentd-1 branch May 3, 2023 16:22
aminesnow pushed a commit to aminesnow/loki that referenced this pull request May 4, 2023
@MattiasSegerdahl
Update _index.md (grafana#9331)
287d16e 
**What this PR does / why we need it**:

**Which issue(s) this PR fixes**:
Fixes #<issue number>

**Special notes for your reviewer**:

**Checklist**
- [ ] Reviewed the
[`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md)
guide (**required**)
- [ ] Documentation added
- [ ] Tests updated
- [ ] `CHANGELOG.md` updated
- [ ] Changes that require user attention or interaction to upgrade are
documented in `docs/sources/upgrading/_index.md`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JStickler JStickler JStickler approved these changes

@kavirajk kavirajk kavirajk approved these changes

Assignees
No one assigned
Labels
size/S type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MattiasSegerdahl @kavirajk @JStickler @jeschkies @GrafanaWriter