Add ruler and recording rules for Loki, Mimir and Tempo #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trevorwhitney
approved these changes
Aug 2, 2023
| @@ -0,0 +1,571 @@ | |||
| groups: | |||
| - name: mimir_api_1 | |||
There was a problem hiding this comment.
should we name this mimir_rules to follow the patter of the the other 2?
There was a problem hiding this comment.
There are a lot more other groups in the mimir rules file. Here's the list once the groups have been collapsed:
groups:
- name: mimir_api_1
- name: mimir_api_2
- name: mimir_api_3
- name: mimir_querier_api
- name: mimir_cache
- name: mimir_storage
- name: mimir_queries
- name: mimir_ingester_queries
- name: mimir_received_samples
- name: mimir_received_exemplars
- name: mimir_exemplars_appended
- name: mimir_scaling_rules
- name: mimir_alertmanager_rules
- name: mimir_ingester_rules
Signed-off-by: Michel Hollands <michel.hollands@gmail.com>
MichelHollands
force-pushed
the
add_ruler
branch
from
1446525
to
8ae136e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a separate ruler just doing these rules.
TODO: this needs to be rebased after #9 was merged because it is based on that one. This makes the PR bigger than it really is. But otherwise it's ready to go.