Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tempo dashboards plus fixes #9

Merged
merged 2 commits into from
Aug 2, 2023
Merged

Conversation

MichelHollands
Copy link
Contributor

This PR adds the Tempo dashboards. Note that these are still just copies of the compiled Tempo mixin.

A new set of values was added as well for the dashboards. You can now turn on dashboards per database. This way you can enable only the dashboards you need.

Signed-off-by: Michel Hollands <michel.hollands@gmail.com>
Copy link
Collaborator

@trevorwhitney trevorwhitney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

once small nit, instead of just naming the configmaps 1-n, can we put the database in there as well, either via subfolders or in the actual filename?

Signed-off-by: Michel Hollands <michel.hollands@gmail.com>
@MichelHollands
Copy link
Contributor Author

looks good.

once small nit, instead of just naming the configmaps 1-n, can we put the database in there as well, either via subfolders or in the actual filename?

Good idea. They were renamed.

@MichelHollands MichelHollands merged commit ac3e446 into main Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants