-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build 24h blocks for older OOO data #751
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
chencs
reviewed
Nov 20, 2024
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
chencs
approved these changes
Nov 20, 2024
chencs
reviewed
Nov 20, 2024
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
codesome
added a commit
that referenced
this pull request
Nov 21, 2024
* Build 24h blocks for older OOO data Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Fix tests Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Add TestBiggerBlocksForOldOOOData Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * lint Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Fix comments Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Fix comment Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> --------- Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
4 tasks
4 tasks
colega
pushed a commit
that referenced
this pull request
Nov 29, 2024
* Build 24h blocks for older OOO data Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Fix tests Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Add TestBiggerBlocksForOldOOOData Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * lint Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Fix comments Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Fix comment Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> --------- Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
colega
pushed a commit
that referenced
this pull request
Nov 29, 2024
* Build 24h blocks for older OOO data Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Fix tests Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Add TestBiggerBlocksForOldOOOData Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * lint Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Fix comments Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Fix comment Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> --------- Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
colega
pushed a commit
that referenced
this pull request
Nov 29, 2024
* Build 24h blocks for older OOO data Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Fix tests Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Add TestBiggerBlocksForOldOOOData Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * lint Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Fix comments Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Fix comment Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> --------- Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
colega
pushed a commit
that referenced
this pull request
Nov 29, 2024
* Build 24h blocks for older OOO data Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Fix tests Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Add TestBiggerBlocksForOldOOOData Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * lint Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Fix comments Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Fix comment Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> --------- Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
colega
pushed a commit
that referenced
this pull request
Nov 29, 2024
* Build 24h blocks for older OOO data Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Fix tests Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Add TestBiggerBlocksForOldOOOData Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * lint Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Fix comments Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Fix comment Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> --------- Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
colega
added a commit
to grafana/mimir
that referenced
this pull request
Nov 29, 2024
This backports the following PRs: - https://github.com/grafana/prometheus/pull/15426 - grafana/mimir-prometheus#751 - grafana/mimir-prometheus#756 Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
4 tasks
colega
added a commit
to grafana/mimir
that referenced
this pull request
Nov 29, 2024
This backports the following PRs: - https://github.com/grafana/prometheus/pull/15426 - grafana/mimir-prometheus#751 - grafana/mimir-prometheus#756 Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
4 tasks
colega
added a commit
to grafana/mimir
that referenced
this pull request
Nov 29, 2024
This backports the following PRs: - https://github.com/grafana/prometheus/pull/15426 - grafana/mimir-prometheus#751 - grafana/mimir-prometheus#763 Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
colega
added a commit
to grafana/mimir
that referenced
this pull request
Nov 29, 2024
This backports the following PRs: - https://github.com/grafana/prometheus/pull/15426 - grafana/mimir-prometheus#751 - grafana/mimir-prometheus#763 Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
colega
added a commit
to grafana/mimir
that referenced
this pull request
Nov 29, 2024
This backports the following PRs: - https://github.com/grafana/prometheus/pull/15426 - grafana/mimir-prometheus#751 - grafana/mimir-prometheus#763 Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
4 tasks
colega
added a commit
to grafana/mimir
that referenced
this pull request
Nov 29, 2024
This backports the following PRs: - prometheus/prometheus#15426 - grafana/mimir-prometheus#751 - grafana/mimir-prometheus#763 Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
colega
added a commit
to grafana/mimir
that referenced
this pull request
Nov 29, 2024
This backports the following PRs: - prometheus/prometheus#15426 - grafana/mimir-prometheus#751 - grafana/mimir-prometheus#763 Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
colega
added a commit
to grafana/mimir
that referenced
this pull request
Nov 29, 2024
This backports the following PRs: - prometheus/prometheus#15426 - grafana/mimir-prometheus#751 - grafana/mimir-prometheus#763 Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
colega
added a commit
to grafana/mimir
that referenced
this pull request
Nov 29, 2024
This backports the following PRs: - prometheus/prometheus#15426 - grafana/mimir-prometheus#751 - grafana/mimir-prometheus#763 Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
colega
added a commit
to grafana/mimir
that referenced
this pull request
Nov 29, 2024
This backports the following PRs: - prometheus/prometheus#15426 - grafana/mimir-prometheus#751 - grafana/mimir-prometheus#763 Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
colega
added a commit
to grafana/mimir
that referenced
this pull request
Nov 29, 2024
This backports the following PRs: - prometheus/prometheus#15426 - grafana/mimir-prometheus#751 - grafana/mimir-prometheus#763 Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For grafana/mimir#9911
In order to reduce the number of blocks when a long OOO window is configured.