[PERF] TSDB: Optimize inverse matching (#14144) #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aknuds1
force-pushed
the
arve/inverse-postings-for-matcher
branch
from
8406d7b
to
c065c55
Compare
Simple follow-up to #13620. Modify `tsdb.PostingsForMatchers` to use the optimized tsdb.IndexReader.PostingsForLabelMatching method also for inverse matching. Introduce method `PostingsForAllLabelValues`, to avoid changing the existing method. The performance is much improved for a subset of the cases; there are up to ~60% CPU gains and ~12.5% reduction in memory usage. Remove `TestReader_InversePostingsForMatcherHonorsContextCancel` since `inversePostingsForMatcher` only passes `ctx` to `IndexReader` implementations now. Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
aknuds1
force-pushed
the
arve/inverse-postings-for-matcher
branch
from
c065c55
to
f319404
Compare
colega
approved these changes
Nov 20, 2024
4 tasks
colega
added a commit
to grafana/mimir
that referenced
this pull request
Nov 29, 2024
This backports the following PRs: - https://github.com/grafana/prometheus/pull/15426 - grafana/mimir-prometheus#751 - grafana/mimir-prometheus#756 Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
4 tasks
colega
added a commit
to grafana/mimir
that referenced
this pull request
Nov 29, 2024
This backports the following PRs: - https://github.com/grafana/prometheus/pull/15426 - grafana/mimir-prometheus#751 - grafana/mimir-prometheus#756 Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick prometheus/prometheus#14144, a querying performance improvement (see upstream PR for benchmark stats).