Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement more helm rego checks #2811

Closed
2 of 6 tasks
dimitarvdimitrov opened this issue Aug 23, 2022 · 2 comments
Closed
2 of 6 tasks

Implement more helm rego checks #2811

dimitarvdimitrov opened this issue Aug 23, 2022 · 2 comments
Labels

Comments

@dimitarvdimitrov
Copy link
Contributor

dimitarvdimitrov commented Aug 23, 2022

A follow-up on #2137

What more checks we can add:

  • all containers have the restricted security context - a test for Deployment mustRunAsNonRoot #2595
  • all pods are covered by some ServiceMonitor/PodLogs; metamonitoring is restricted to pod from the chart
  • some implicit naming conventions: to scrape PVC volumes information for metamonitoring (helm: meta-monitoring #2068) we assume that the PVCs created by the chart have a storage- prefix. If this prefix is changed in any of the StatefulSets the metamonitoring will break and stop collecting data for the volumes. We have no way of knowing this during the review process now.
  • Verify that all component have an attached volume under /data. The default mimir.config assumes /data is a mounted directory.
  • all resources have the standard kubernetes annotations (app.kubernetes.io/)
  • verify that all resources have an explicit namespace (Helm: fix namespace issues #2123)
@mattmendick
Copy link
Contributor

Removing the squad/customer label from this issue since this is a bit of a pet project. If you feel like this should be something that a larger group of people chip away at officially, put it on the next quarter planning spreadsheet. Creating smaller issues made from this might be another good strategy.

@dimitarvdimitrov
Copy link
Contributor Author

I don't have plans to work on this anymore, so I'm closing it

@dimitarvdimitrov dimitarvdimitrov closed this as not planned Won't fix, can't repro, duplicate, stale Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants