Helm: fix namespace issues #2123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Should update minio to a newer version as well to get the namespace definitions in minio subchart templates. |
dimitarvdimitrov
approved these changes
Jun 20, 2022
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> Co-authored-by: Rasmus Dencker <rd@firtal.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> Co-authored-by: Rasmus Dencker <rd@firtal.com>
Add namespace and namespaceSelector default values. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> Co-authored-by: Rasmus Dencker <rd@firtal.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Does not work in CI as there is no Prom Monitor installed so CRDs are not defined. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
krajorama
force-pushed
the
krajo/20220617-fix-namespace
branch
from
5d3ea62 to
a0b6f88
Compare
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
dimitarvdimitrov
approved these changes
Jun 21, 2022
|
I testing installing this via helm template and only got the minio resources in the current namespace as opposed to the namespace from the |
masonmei
pushed a commit
to udmire/mimir
that referenced
this pull request
Jul 11, 2022
* Helm: add namespace specification to all objects * Helm: add some default values for ServiceMonitor objects Add namespace and namespaceSelector default values. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> Co-authored-by: Rasmus Dencker <rd@firtal.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Add namespace definitions to kubernetes objects so that helm install works correctly even if the namespace does not exist yet.
Add default namespace definition and default namespace selector for ServiceMonitor objects.
Which issue(s) this PR fixes or relates to
Fixes #2045
Based on: #2040
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]