helm: meta-monitoring #2068
Merged
helm: meta-monitoring #2068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logiraptor
requested changes
Jun 13, 2022
operations/helm/charts/mimir-distributed/templates/metamonitoring/_helpers.tpl
Outdated
Show resolved
Hide resolved
| metaMonitoring: | ||
| grafanaAgent: | ||
| # -- Controls whether to create PodLogs, MetricsInstance, LogsInstance, and GrafanaAgent CRs to scrape the | ||
| # ServiceMonitors of the chart and ship metrics and logs to the remote endpoints below. |
There was a problem hiding this comment.
it doesn't work with the defaults. And yes, the ServiceMonitors need to be enabled. I will clarify this in the docs
krajorama
reviewed
Jun 15, 2022
krajorama
reviewed
Jun 15, 2022
krajorama
reviewed
Jun 16, 2022
replay
reviewed
Jun 17, 2022
dimitarvdimitrov
force-pushed
the
dimitar/helm-chart-metamonitoring
branch
from
ca9e934 to
801d0d7
Compare
|
@dimitarvdimitrov this PR was very inspiring, just put up something similar for Loki: grafana/helm-charts#1514 |
|
I realized there is no service monitor for the overrides exporter I will add one |
#2125 adds a new helper for serviceomonitors. I will wait for that to be merged before adding one here. Looks be trivial. |
dimitarvdimitrov
force-pushed
the
dimitar/helm-chart-metamonitoring
branch
from
5e2a8a4 to
d02efbc
Compare
2 tasks
dimitarvdimitrov
force-pushed
the
dimitar/helm-chart-metamonitoring
branch
from
d02efbc to
0f867d5
Compare
krajorama
reviewed
Jun 21, 2022
krajorama
reviewed
Jun 21, 2022
operations/helm/charts/mimir-distributed/templates/metamonitoring/grafana-agent.yaml
Outdated
Show resolved
Hide resolved
krajorama
approved these changes
Jun 21, 2022
Logiraptor
requested changes
Jun 22, 2022
operations/helm/charts/mimir-distributed/templates/metamonitoring/_helpers.tpl
Show resolved
Hide resolved
krajorama
reviewed
Jun 23, 2022
operations/helm/charts/mimir-distributed/templates/validate.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
dimitarvdimitrov
force-pushed
the
dimitar/helm-chart-metamonitoring
branch
from
dbb7977 to
2a67ba3
Compare
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
3 tasks
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Logiraptor
approved these changes
Jun 24, 2022
rlex
added a commit
to rlex/mimir
that referenced
this pull request
Jun 28, 2022
* main: (63 commits) Add new section on website for links to blog posts, podcasts and talks. (grafana#2216) Rename codified errors to errors catalog (grafana#2256) Helm: add a step to contributing doc (grafana#2257) Signal that 2.2 release is now in progress. (grafana#2254) Removed migration of alertmanager local state files from old hierarchy (Cortex 1.8 and earlier) (grafana#2253) operations/mimir: Change multi_zone_ingester_max_unavailable to 25 (grafana#2251) Helm: weekly release (grafana#2252) Jsonnet: Configure ingester max global metadata per user and per metric (grafana#2250) Helm: metamonitor naming (grafana#2236) Mimir documentation about out-of-order (grafana#2183) Vendor latest mimir-prometheus/main (grafana#2243) Set CODEOWNERS to primary technical writer (grafana#2242) Use BasicLifecycler for distributors and auto-forget (grafana#2154) Docs: Basic documentation for deploying the ruler using jsonnet. (grafana#2127) Fix post merge reviews on 2187 (grafana#2230) Add tests for user metadata in the ingester (grafana#2184) Change the error message template for per-tenant limits (grafana#2234) helm: meta-monitoring (grafana#2068) Article about migrating from Consul to memberlist. Added documentation for /memberlist endpoint. (grafana#2166) Update runbooks to mention possibility to investigate memberlist KV store in various alerts (grafana#2158) ...
masonmei
pushed a commit
to udmire/mimir
that referenced
this pull request
Jul 11, 2022
* Add meta-monitoring Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Aims to make monitoring of Mimir/GEM when deployed via the helm chart easier. The idea is to make the process as streamlined as possible so that an operator has to spend minimal time on configuring scraping and relabelling configs.
This PR tries to achieve this by vendoring the Grafana Agent Operator helm chart. The mimir-distributed chart creates custom resources that create two grafana agents: one that scrapes metrics and one that collects logs. Optionally the mimir chart can also create resources that scrape relevant metrics from cadvisor, kubelet, and kube-state-metrics because these are used in alerts and dashboards.
Which issue(s) this PR fixes or relates to
Fixes #2014
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]