Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/escalate Slack Dropdown Duplicates Teams for Each Route in Direct Paging #3388

Closed
ESNewmanium opened this issue Nov 20, 2023 · 0 comments · Fixed by #3590
Closed

/escalate Slack Dropdown Duplicates Teams for Each Route in Direct Paging #3388

ESNewmanium opened this issue Nov 20, 2023 · 0 comments · Fixed by #3590
Assignees
@joeyorlando
Labels
bug Something isn't working part:chatops

Comments

@ESNewmanium
Copy link
Contributor

What went wrong?

What happened:

  • Teams with more than 1 Route defined in Direct Paging are being duplicated in the Create Escalation menu from the /escalate command. e.g. a Direct Paging Integration with 3 routes will be shown 3 times in the "Team to notify" menu (pictured below). It seems to stop incrementing at 3 (e.g. making 5 routes doesn't create 5 entries in the dropdown) but I don't know what to make of why that is.

What did you expect to happen:

  • Expected that each Team would only appear once in the "Team to notify" dropdown menu.
Screenshot 2023-11-20 110420

Screenshot 2023-11-20 110758

How do we reproduce it?

  1. Create a Direct Paging Integration for a team.
  2. Create 2 or more Routes for that team's Direct Paging.
  3. Run the /escalate command in Slack, then select "Team to notify" -- in screenshots pictured above there are duplicate entries for this team displayed.

Grafana OnCall Version

v1.3.59

Product Area

Chatops

Grafana OnCall Platform?

Kubernetes

User's Browser?

Slack Production 4.35.126

Anything else to add?

No response
@ESNewmanium ESNewmanium added the bug Something isn't working label Nov 20, 2023
@joeyorlando joeyorlando self-assigned this Dec 18, 2023
@joeyorlando joeyorlando mentioned this issue Dec 19, 2023
Merged
3 tasks
github-merge-queue bot pushed a commit that referenced this issue Dec 22, 2023
@joeyorlando
fix duplicate teams showing up in teams dropdown for /escalate slac…
9657533 
…k command (#3590)

# Which issue(s) this PR fixes
- Closes grafana/support-escalations#8763
- Closes #3388

## Checklist

- [x] Unit, integration, and e2e (if applicable) tests updated
- [ ] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not
required)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joeyorlando joeyorlando

Labels
bug Something isn't working part:chatops
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix duplicate teams showing up in teams dropdown for /escalate slack command grafana/oncall
2 participants
@joeyorlando @ESNewmanium