fix duplicate teams showing up in teams dropdown for /escalate slack command
#3590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for /escalate slack command
joeyorlando
added
the
pr:no public docs
joeyorlando
commented
Dec 19, 2023
Comment on lines
-36
to
-41
| ### Fixed | ||
|
|
||
| - Fix PUT /api/v1/escalation_policies/id issue when updating `from_time` and `to_time` by @joeyorlando ([#3581](https://github.com/grafana/oncall/pull/3581)) | ||
|
|
There was a problem hiding this comment.
I added this to the wrong section, this hasn't been released yet
joeyorlando
commented
Dec 19, 2023
| | Q(channel_filters__is_default=True, channel_filters__notification_backends__isnull=False), | ||
| integration=AlertReceiveChannel.INTEGRATION_DIRECT_PAGING, | ||
| ) | ||
| .distinct() |
There was a problem hiding this comment.
only change is the addition of .distinct() here (rest is formatting)
matiasb
approved these changes
Dec 22, 2023
joeyorlando
deleted the
jorlando/fix-direct-paging-duplicate-teams-bug
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes
Checklist
pr:no public docsPR label added if not required)CHANGELOG.mdupdated (orpr:no changelogPR label added if not required)