Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schedule Filters tweaks #1406

Merged
merged 19 commits into from
Mar 1, 2023
Merged

Schedule Filters tweaks #1406

merged 19 commits into from
Mar 1, 2023

Conversation

teodosii
Copy link
Member

@teodosii teodosii commented Feb 24, 2023 •
edited
Loading

What this PR does

Improvements over schedule filters

Which issue(s) this PR fixes

#941

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated

@teodosii teodosii requested a review from a team February 24, 2023 10:31
@teodosii teodosii added the pr:no public docs Added to a PR that does not require public documentation updates label Feb 24, 2023
@maskin25
Copy link
Contributor

in my mind you just need to remove line store.scheduleStore.updateItems(); from pages/schedules/Schedules.tsx -> componentDidMount method, and add

useEffect(() => {
    onChange(value);
  }, []);

in SchedulesFilters.tsx to immediately apply initial filters after SchedulesFilters mounts

maskin25
maskin25 suggested changes Feb 24, 2023
View reviewed changes
grafana-plugin/src/pages/schedules/Schedules.tsx Outdated Show resolved Hide resolved
grafana-plugin/src/pages/schedules/Schedules.tsx Outdated Show resolved Hide resolved
@teodosii teodosii added this pull request to the merge queue Mar 1, 2023
Merged via the queue into dev with commit 1b0643f Mar 1, 2023
@teodosii teodosii deleted the rares/schedule-filters-941 branch March 1, 2023 13:35
@teodosii teodosii mentioned this pull request Mar 1, 2023
Closed
@matiasb matiasb mentioned this pull request Jun 22, 2023
Merged
brojd pushed a commit that referenced this pull request Sep 18, 2024
@teodosii
Schedule Filters tweaks (#1406)
7f04746 
# What this PR does

Improvements over schedule filters

## Which issue(s) this PR fixes

#941 

## Checklist

- [ ] Tests updated
- [ ] Documentation added
- [x] `CHANGELOG.md` updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maskin25 maskin25 maskin25 approved these changes

Assignees
No one assigned
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teodosii @maskin25