v1.2.46 #2313
Merged
v1.2.46 #2313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add descriptions for fields - Change default value of request_data to avoid confusing situation where if there was a error before request data is built, like in the template for the request headers, request_data would be a python dict resulting in hard to read text in the UI status page.
…g on call push notification text (#2131) # What this PR does - add user locale field to mobile app user settings table + add a test that sends `PATCH` requests to this endpoint - change "you're going on call" push notification text to include localized shift time. The general format is now: ```python f"You're going on call in {time_until_going_oncall} for schedule {schedule.name}, {formatted_shift}" ``` - `time_until_going_oncall` is a "human-readable" format of the time until the start) - `schedule.name` is self-explanatory - `formatted_shift` this depends on the shift. If the shift starts and ends on the same day, the format will be "HH:mm - HH:mm". Otherwise, if the shift starts and ends on different days, the format will be "YYYY-MM-DD HH:mm - YYYY-MM-DD HH:mm". **Note** that all datetime related formatting will use the new `locale` field that we are now storing in the mobile app user settings table. If no locale is yet present we will fallback to "en" ## Which issue(s) this PR fixes closes #2024 grafana/oncall-mobile-app#187 ## Checklist - [x] Unit, integration, and e2e (if applicable) tests updated - [ ] Documentation added (or `pr:no public docs` PR label added if not required) - [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required)
Porting changes from #1833
# What this PR does ## Which issue(s) this PR fixes - Fixed route expansion in templates&grouping - Added notifications for add/delete routes
This is how `grafana/grafana` handles [bug reports](https://github.com/grafana/grafana/issues/new?assignees=&labels=&projects=&template=0-bug-report.yaml&title=Product-Area-Here%3A+short+description+of+bug+here) (for feature requests they have an [external link](https://github.com/grafana/grafana/issues/new/choose) pointing people to head over to their repo's Discussion page). This _should_ solve the problem of people opening new issues without properly filling in all the necessary information. Because users that are not a part of the `grafana` GitHub organization, do not have permission to add labels, this also solves that by automatically adding either the "bug" or "feature request" label based on which issue template they choose to use.
# What this PR does ## Which issue(s) this PR fixes ## Checklist - [ ] Unit, integration, and e2e (if applicable) tests updated - [ ] Documentation added (or `pr:no public docs` PR label added if not required) - [ ] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required)
# What this PR does ## Which issue(s) this PR fixes ## Checklist - [ ] Unit, integration, and e2e (if applicable) tests updated - [ ] Documentation added (or `pr:no public docs` PR label added if not required) - [ ] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required)
**What this PR does**: The existing value brokes the release when using external RabbitMQ. ``` Warning Failed 6s (x11 over 112s) kubelet Error: couldn't find key password in Secret monitoring/oncall-rabbitmq-external ``` **Which issue(s) this PR fixes**: Related MR [#761](#761) **Checklist** - [ ] Tests updated - [ ] Documentation added - [ ] `CHANGELOG.md` updated --------- Co-authored-by: Ildar Iskhakov <Ildar.iskhakov@grafana.com>
# What this PR does Remove deprecated `permissions` `List[str]` from internal API user response. These permission strings are no longer used and AFAICT are not referenced anywhere in the UI. ## Checklist - [x] Unit, integration, and e2e (if applicable) tests updated - [ ] Documentation added (or `pr:no public docs` PR label added if not required) (N/A) - [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required)
# What this PR does ## Which issue(s) this PR fixes ## Checklist - [ ] Unit, integration, and e2e (if applicable) tests updated - [ ] Documentation added (or `pr:no public docs` PR label added if not required) - [ ] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required) --------- Co-authored-by: Ruslan Gainanov <gromrx1@gmail.com> Co-authored-by: Yulia Shanyrova <yulia.shanyrova@grafana.com>
# What this PR does ## Which issue(s) this PR fixes ## Checklist - [ ] Unit, integration, and e2e (if applicable) tests updated - [ ] Documentation added (or `pr:no public docs` PR label added if not required) - [ ] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required) --------- Co-authored-by: Innokentii Konstantinov <innokenty.konstantinov@grafana.com>
…get (#2284) # What this PR does install `requirements-dev.txt` dependencies oncall docker image dev target to allow commands like `make test` to properly work. Otherwise you currently get: ```bash Error response from daemon: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: exec: "pytest": executable file not found in $PATH: unknown make: *** [test] Error 1 ``` ## Checklist - [ ] Unit, integration, and e2e (if applicable) tests updated - [ ] Documentation added (or `pr:no public docs` PR label added if not required) - [ ] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required)
# What this PR does Plus mark `alert_receive_channel.restricted_at` column as deprecated. This column will be removed in a future release. ## Checklist - [ ] Unit, integration, and e2e (if applicable) tests updated (N/A) - [ ] Documentation added (or `pr:no public docs` PR label added if not required) (N/A) - [ ] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required) (N/A)
# What this PR does ## Which issue(s) this PR fixes ## Checklist - [x] Unit, integration, and e2e (if applicable) tests updated - [x] Documentation added (or `pr:no public docs` PR label added if not required) - [ ] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required) --------- Co-authored-by: Joey Orlando <joseph.t.orlando@gmail.com> Co-authored-by: Joey Orlando <joey.orlando@grafana.com>
# What this PR does - Description of Alert Manager info box was changed - Fix for filtering Escalation chains in Integration - Alt text for Image template - Conditional result for Template was fixed
# What this PR does Features and bugs related to [[Q1 2023] Iteration with Schedules](https://github.com/grafana/oncall-private/issues/1660) milestone ## Which issue(s) this PR fixes ## Checklist - [x] Unit, integration, and e2e (if applicable) tests updated - [ ] Documentation added (or `pr:no public docs` PR label added if not required) - [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required) --------- Co-authored-by: Innokentii Konstantinov <innokenty.konstantinov@grafana.com> Co-authored-by: Matias Bordese <mbordese@gmail.com>
# What this PR does ## Which issue(s) this PR fixes ## Checklist - [ ] Unit, integration, and e2e (if applicable) tests updated - [ ] Documentation added (or `pr:no public docs` PR label added if not required) - [ ] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required)
Updating a schedule using the web UI sometimes you don't get the change immediately available (since the ical refresh is async). Related to #1968
- [x] Alert group scroll - [x] Result scroll right padding - [x] Cheatsheet scroll right padding - [x] Template editor and cheatsheet title alight center - [x] Edit custom payload - left padding - [x] Change background of Use custom payload title like Template Editor - [x] No alert groups is missing right border - [x] Save template - should not close the drawer if there is an error - [x] Width cheatsheet code 100% - [x] Edit/close Alert payload margin 8px - [x] Background secondary Result - when Select alert group message
# What this PR does - Fixed newlines in cheatsheat display - Reference templates by keys instead of display names - UI esthetic changes asked by Raphael (borders, sizing, spacing etc) - Increased Demo Alert Modal height - Moved MoveUp/MoveDown on routes to ellipsis on the right - Hide Heartbeat Settings if there's none to display - Removed Telegram request as now the data is available in response
Optimize getting response time for alert groups in calculation metrics task ## Checklist - [ ] Unit, integration, and e2e (if applicable) tests updated - [ ] Documentation added (or `pr:no public docs` PR label added if not required) - [ ] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required)
Add dashboard for oncall metrics to the plugin settings by following [this instruction](https://community.grafana.com/t/how-to-include-dashboards-in-your-data-source-plugin/62749). Dashboards files should be in `.json` format and stored in the plugin's directory in `/src/dashboards/`. As the result the dashboard can be imported from the `Dashboards` tab at the plugin settings page: <img width="1504" alt="Screenshot 2023-06-21 at 11 28 31" src="https://github.com/grafana/oncall/assets/22730923/8c2bfe4a-f3c8-480a-b18c-7ba21a9b8e30"> --------- Co-authored-by: Joey Orlando <joey.orlando@grafana.com>
# What this PR does - Fixed a few issues when using the light theme - Show/Hide Escalation - Search Escalation - Reload Escalation (all fixes) - Inbound Email show in http endpoint - Allow opening the route template in collapsed state (added new button for it)
# What this PR does ## Which issue(s) this PR fixes ## Checklist - [ ] Unit, integration, and e2e (if applicable) tests updated - [x] Documentation added (or `pr:no public docs` PR label added if not required) - [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required) --------- Co-authored-by: Matias Bordese <mbordese@gmail.com>
# What this PR does Fixes an issue when multiple user notification policies have duplicated order values, leading to the following unexpected behaviours: 1. Not possible to rearrange notification policies that have duplicated orders. 2. The notification system only executes the first policy from each order group. For example, if there are policies with orders `[0, 0, 0, 0]`, only the first policy will be executed, and all others will be skipped. So the user will see four policies in the UI, while only one of them will be actually executed. This PR fixes the issue by adding a unique index on `(user_id, important, order)` for `UserNotificationPolicy` model. However, it's not possible to add that unique index using the ordering library that we use due to it's implementation details. I added a new abstract Django model `OrderedModel` that's able to work with such unique indices + under concurrent load. Important info on this new `OrderedModel` abstract model: - Orders are unique on the DB level - Orders are allowed to be non-consecutive, for example order sequence `[100, 150, 400]` is valid - When deleting an instance, orders of other instances don't change. This is a notable difference from the library we use. I think it's better to only delete the instance without changing any other orders, because it reduces the number of dependencies between instances (e.g. Terraform drift will be much smaller this way if a policy is deleted via the web UI). ## Which issue(s) this PR fixes Related to grafana/oncall-private#1680 ## Checklist - [x] Unit, integration, and e2e (if applicable) tests updated - [x] Documentation added (or `pr:no public docs` PR label added if not required) - [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required)
# What this PR does - light theme fixes for templates&grouping
…nsistent (#2295) # What this PR does This PR changes Alert Group layout according to the feedback from this issue #2008 Also it makes time format more consistent across OnCall ## Which issue(s) this PR fixes ## Checklist - [ ] Unit, integration, and e2e (if applicable) tests updated - [ ] Documentation added (or `pr:no public docs` PR label added if not required) - [ ] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required)
# What this PR does ## Which issue(s) this PR fixes ## Checklist - [ ] Unit, integration, and e2e (if applicable) tests updated - [ ] Documentation added (or `pr:no public docs` PR label added if not required) - [ ] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required)
# What this PR does ## Which issue(s) this PR fixes ## Checklist - [ ] Unit, integration, and e2e (if applicable) tests updated - [ ] Documentation added (or `pr:no public docs` PR label added if not required) - [ ] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required)
[css fixes, displaying chatops button visibility fix]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Changed
Fixed