Simplify SlackEventApiEndpointView methods
#2384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadimkerr
added
pr:no changelog
pr:no public docs
vadimkerr
commented
Jun 28, 2023
| @@ -79,8 +82,6 @@ | |||
|
|
|||
| logger = logging.getLogger(__name__) | |||
|
|
|||
| SELECT_ORGANIZATION_AND_ROUTE_BLOCK_ID = "SELECT_ORGANIZATION_AND_ROUTE" | |||
There was a problem hiding this comment.
I couldn't find any usages, so removing it.
vadimkerr
changed the title
SlackEventApiEndpointView._get_organization_from_payloadSlackEventApiEndpointView methods
vadimkerr
commented
Jun 28, 2023
|
|
||
| try: | ||
| slack_team_identity = SlackTeamIdentity.objects.get(slack_id=slack_team_id) | ||
| except SlackTeamIdentity.DoesNotExist as e: | ||
| logger.warning("Team identity not detected, that's dangerous!" + str(e)) |
joeyorlando
approved these changes
Jun 29, 2023
|
@joeyorlando Thank you for the review! I'm currently working on #2336 and it will introduce a few changes to the Slack view, so I'm planning to add tests on most of this logic in subsequent PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Simplifies
_get_organization_from_payloadand_get_slack_team_identity_from_payloadmethods onSlackEventApiEndpointView, so it's (hopefully) easier to grasp.Checklist
pr:no public docsPR label added if not required)CHANGELOG.mdupdated (orpr:no changelogPR label added if not required)