Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make adding responders in Slack consistent with web UI #2336

Closed
vadimkerr opened this issue Jun 26, 2023 · 2 comments
Closed

Make adding responders in Slack consistent with web UI #2336

vadimkerr opened this issue Jun 26, 2023 · 2 comments
Assignees
@vadimkerr @raphael-batte
Labels
feature request New feature or request part:chatops

Comments

@vadimkerr
Copy link
Member

vadimkerr commented Jun 26, 2023 •
edited
Loading

Alert group messages in Slack have this "Invite..." dropdown:

Screenshot 2023-06-26 at 10 19 09

It's not consistent with the "Add Responders" button in web UI:

  • Users invited via Slack don't show up in responder list
  • It's not possible to page a schedule via Slack
  • "Invite..." dropdown uses an outdated mechanism for paging users, which has been superseded by Direct Paging
  • The list of users in dropdown is static, which may lead to outdated user selection & unnecessary large payload size when sending messages to Slack API.

"Inviting" users in Slack should be similar to /escalate command, allowing to select schedules / users to page for an existing alert group:

Screenshot 2023-06-26 at 10 37 28
@vadimkerr vadimkerr added the feature request New feature or request label Jun 26, 2023
@github-actions
Copy link
Contributor

The current version of Grafana OnCall, at the time this issue was opened, is v1.2.46. If your issue pertains to an older version of Grafana OnCall, please be sure to list it in the PR description. Thank you 😄!

@vadimkerr vadimkerr self-assigned this Jun 26, 2023
@raphael-batte
Copy link

Any opinions about this order by default?
image

@raphael-batte raphael-batte self-assigned this Jun 27, 2023
@vadimkerr vadimkerr mentioned this issue Jun 29, 2023
Merged
3 tasks
@Matvey-Kuk Matvey-Kuk mentioned this issue Jul 5, 2023
Closed
@vadimkerr vadimkerr mentioned this issue Jul 10, 2023
Closed
@vadimkerr vadimkerr mentioned this issue Jul 17, 2023
Merged
3 tasks
github-merge-queue bot pushed a commit that referenced this issue Jul 18, 2023
@vadimkerr
Update Slack "invite" feature to use direct paging (#2562)
5674385 
# What this PR does

Refactors the "invite" functionality in Slack to use direct paging and
be more consistent with the web UI and `/escalate` Slack command.

## Screenshots

### Alert group buttons

Before:

<img width="609" alt="Screenshot 2023-07-17 at 22 40 47"
src="https://github.com/grafana/oncall/assets/20116910/68fad5a4-5011-4d74-b1c7-362bdb4f8cf0">


After (replace "Invite..." dropdown with "Responders" button, swap it
with the silence button):
<img width="587" alt="Screenshot 2023-07-17 at 22 37 19"
src="https://github.com/grafana/oncall/assets/20116910/50b42057-f46b-4558-ab1c-56c34a15af5e">


### What happens when clicking on "Responders"

The following modal opens up with a list of currently paged users and
inputs to page more users/schedules:

<img width="514" alt="Screenshot 2023-07-17 at 22 37 52"
src="https://github.com/grafana/oncall/assets/20116910/70bd2853-d459-4343-8b25-8519ac0098f7">

This is supposed to be the Slack equivalent of this part of the web UI:

<img width="601" alt="Screenshot 2023-07-17 at 22 47 17"
src="https://github.com/grafana/oncall/assets/20116910/101e1229-a5c4-404f-8388-eceee3e4820f">


## Which issue(s) this PR fixes

#2336

## Checklist

- [x] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not
required)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vadimkerr vadimkerr

@raphael-batte raphael-batte

Labels
feature request New feature or request part:chatops
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vadimkerr @raphael-batte