Update Slack "invite" feature to use direct paging #2562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadimkerr
added
the
pr:no public docs
vadimkerr
changed the title
vadimkerr
changed the title
vadimkerr
commented
Jul 17, 2023
| @@ -498,6 +498,23 @@ def declare_incident_link(self) -> str: | |||
| def happened_while_maintenance(self): | |||
| return self.root_alert_group is not None and self.root_alert_group.maintenance_uuid is not None | |||
|
|
|||
| def get_paged_users(self) -> QuerySet[User]: | |||
There was a problem hiding this comment.
moving from here to make it reusable
| @@ -28,7 +28,7 @@ | |||
|
|
|||
| def _trigger_alert( | |||
| organization: Organization, | |||
| team: Team, | |||
| team: Team | None, | |||
There was a problem hiding this comment.
team is None for No Team (aka default team)
| @@ -212,6 +212,11 @@ def process_scenario(self, slack_user_identity, slack_team_identity, payload): | |||
|
|
|||
|
|
|||
| class InviteOtherPersonToIncident(AlertGroupActionsMixin, scenario_step.ScenarioStep): | |||
| """ | |||
| THIS SCENARIO STEP IS DEPRECATED AND WILL BE REMOVED IN THE FUTURE. | |||
There was a problem hiding this comment.
These are now deprecated, since new messages are rendered without the "Invite..." dropdown.
Leaving the old scenario steps for now so the old messages can be processed.
There was a problem hiding this comment.
Contents of this file are very similar to apps/slack/scenarios/paging.py, and some parts are reused (e.g. generating availability warnings)
| @@ -753,7 +753,25 @@ def _get_selected_entries_list(input_id_prefix, key, entries): | |||
|
|
|||
| def _display_availability_warnings(payload, warnings, organization, user): | |||
| metadata = json.loads(payload["view"]["private_metadata"]) | |||
| return _get_availability_warnings_view( | |||
There was a problem hiding this comment.
This is moved from here, so there's a new function _get_availability_warnings_view that can be reused.
joeyorlando
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Refactors the "invite" functionality in Slack to use direct paging and be more consistent with the web UI and
/escalateSlack command.Screenshots
Alert group buttons
Before:
After (replace "Invite..." dropdown with "Responders" button, swap it with the silence button):
What happens when clicking on "Responders"
The following modal opens up with a list of currently paged users and inputs to page more users/schedules:
This is supposed to be the Slack equivalent of this part of the web UI:
Which issue(s) this PR fixes
#2336
Checklist
pr:no public docsPR label added if not required)CHANGELOG.mdupdated (orpr:no changelogPR label added if not required)