Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instruct jest to transform all packages (including all inside node_modules) #112

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

academo
Copy link
Member

@academo academo commented Oct 24, 2022

Closes #111

This is an initial solution to the problem described in #111

It is not feaseable for now to create an maintain a list of packages that need transformation and we'll investigate later in the future a better performant solution.

For now, even though slower, this guarantees tests to run inside jest with ESM and commonjs code.

@academo academo requested review from andresmgot and jackw October 24, 2022 14:47
@academo academo self-assigned this Oct 24, 2022
@academo academo added the bug label Oct 24, 2022
@academo academo added this to the v1.0.0 milestone Oct 24, 2022
Copy link
Collaborator

@jackw jackw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work on this @academo ! 🚀

Copy link
Contributor

@andresmgot andresmgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@academo academo merged commit 4ff8719 into main Oct 25, 2022
@academo academo deleted the academo/jest-transform-all-the-things branch October 25, 2022 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Jest tests are failing due to some node_modules not being transpiled before loading
3 participants