Create-Plugin: Transform known ES modules in jest config #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackw
added
bug
create-plugin
leventebalogh
previously approved these changes
Nov 14, 2022
| @@ -5,6 +5,8 @@ | |||
| */ | |||
|
|
|||
| const path = require('path'); | |||
| // Jest will throw errors if it tries to load an es module with it being transformed first | |||
| const esModules = ['ol', 'react-colorful'].join('|'); | |||
There was a problem hiding this comment.
Maybe it would make sense to update the comment and the name of the variable to reflect more what problems one can solve with adding package names here and when it should be used? Probably it would also make sense to export it so plugin devs can extend it in their own config more easily?
Suggested change
| const esModules = ['ol', 'react-colorful'].join('|'); | |
| // Just an idea, maybe we can find a better name | |
| const esModuleNpmPackages = ['ol', 'react-colorful'].join('|'); |
jackw
changed the title
|
🚀 PR was released in |
|
@jackw This causes some issues, maybe something missing in the migration script? https://drone.grafana.net/grafana/clock-panel/35/1/5 |
Thanks for the heads up @tolzhabayev I'll get it fixed! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The previous PR that addressed issues with loading es modules by transforming all modules in node_modules introduced an issue where SWC will error if a package contains code the typescript compiler doesn't appreciate.
One example of this is reassignment of a class (something we do in grafana/data).
I'm not sure if there's a better way to solve this but I'm now leaning towards maintaining a list of packages as a solution mentioned in #111.
Which issue(s) this PR fixes:
Fixes #111
Special notes for your reviewer:
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
npm install @grafana/create-plugin@0.5.2-canary.145.6b7c318.0 # or yarn add @grafana/create-plugin@0.5.2-canary.145.6b7c318.0