Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User Agent String should indentify synthetic-monitoring-agent #117

Closed
electron0zero opened this issue Feb 4, 2021 · 0 comments · Fixed by #150
Closed

User Agent String should indentify synthetic-monitoring-agent #117

electron0zero opened this issue Feb 4, 2021 · 0 comments · Fixed by #150
Labels
enhancement New feature or request

Comments

@electron0zero
Copy link
Member

electron0zero commented Feb 4, 2021 •
edited
Loading

synthetic-monitoring-agent should identify itself with appropriate user agent string to make it easy for operators to identify where the traffic is coming from.

also see: prometheus/blackbox_exporter#557
@electron0zero electron0zero added the enhancement New feature or request label Feb 4, 2021
@electron0zero electron0zero mentioned this issue Apr 12, 2021
Closed
mem added a commit that referenced this issue Apr 26, 2021
@mem
Set user agent in outgoing HTTP requests
12c1465 
The user agent identifies the synthetic monitoring agent version, OS,
architecture, buildstamp and commit hash, and it points to the synthetic
monitoring product page on grafana.com so that people can more easily
identify requests as coming from Synthetic Monitoring.

The more explicit user agent version is also passed to Prometheus so
that it's easier to identify issues.

Closes #142 #117

Signed-off-by: Marcelo E. Magallon <marcelo.magallon@grafana.com>
@mem mem mentioned this issue Apr 26, 2021
Merged
@mem mem linked a pull request Apr 26, 2021 that will close this issue
Set user agent in outgoing HTTP requests #150
Merged
mem added a commit that referenced this issue Apr 27, 2021
@mem
Set user agent in outgoing HTTP requests
d49f7df 
The user agent identifies the synthetic monitoring agent version, OS,
architecture, buildstamp and commit hash, and it points to the synthetic
monitoring product page on grafana.com so that people can more easily
identify requests as coming from Synthetic Monitoring.

The more explicit user agent version is also passed to Prometheus so
that it's easier to identify issues.

Closes #142 #117

Signed-off-by: Marcelo E. Magallon <marcelo.magallon@grafana.com>
mem added a commit that referenced this issue Apr 27, 2021
@mem
Set user agent in outgoing HTTP requests
82d612a 
The user agent identifies the synthetic monitoring agent version, OS,
architecture, buildstamp and commit hash, and it points to the synthetic
monitoring product page on grafana.com so that people can more easily
identify requests as coming from Synthetic Monitoring.

The more explicit user agent version is also passed to Prometheus so
that it's easier to identify issues.

Closes #142 #117

Signed-off-by: Marcelo E. Magallon <marcelo.magallon@grafana.com>
@mem mem closed this as completed in #150 Apr 28, 2021
mem added a commit that referenced this issue Apr 28, 2021
@mem
Set user agent in outgoing HTTP requests
b6cefeb 
The user agent identifies the synthetic monitoring agent version, OS,
architecture, buildstamp and commit hash, and it points to the synthetic
monitoring product page on grafana.com so that people can more easily
identify requests as coming from Synthetic Monitoring.

The more explicit user agent version is also passed to Prometheus so
that it's easier to identify issues.

Closes #142 #117

Signed-off-by: Marcelo E. Magallon <marcelo.magallon@grafana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set user agent in outgoing HTTP requests grafana/synthetic-monitoring-agent
1 participant
@electron0zero