-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default user agent #557
Change default user agent #557
Conversation
According to prometheus scrape behavior. Change default go http client user-agent from "Go-http-client/1.1" to "{{ project_name }}/{{ version }}" Signed-off-by: nikosmonaut <nikosmonaut@protonmail.ch>
ff2a54a
to
305e88c
Compare
Signed-off-by: nikosmonaut <nikosmonaut@protonmail.ch>
51d7044
to
36b2245
Compare
By the way I checked the case of null value. I tried to remove the omitempty but no changes
|
omitempty affects marshalling, not unmarshalling. Null values are fun, we've had many bugs due to them. |
This seems like a useful change. Is there some work to do besides fixing the conflicts? |
Hmm, looks like that's the case. Better handling of not sending the header at all would also be good. |
Yo. Would you like me to do anything ? Honestly I'm not sure what to do about this PR. I followed this issue #555, and it's been one year with no update on this PR nor the issue. Is it still useful ? Personnaly I just set the User-Agent to BlackBox in config yml to get the same behaviour. Edit : Sentence meaning |
It is still useful. It's technically breaking, but it doesn't hurt to help track where requests are coming from. Resolving the conflicts, and allowing for no header to be set if practical, would be good. |
any progress? |
I'd also like to see this merged. Use case: |
Going to close and re-open this to see if the tests still pass. |
Seems like this is ready to go. |
Hello.
According to prometheus scrape behavior here Change default go http client user-agent
from "Go-http-client/1.1" to "BlackBox Exporter/{{ version }}"
Issue : #555
Maintainers : @brian-brazil