Fix: use uniform timeout validation logic #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should be using the same timeout validation logic for adhoc and regular checks. The downside of this is that adhoc checks with long timeouts might take a long time to run. We can fix this by introducing some observability and figuring out if that's a problem or not. Signed-off-by: Marcelo E. Magallon <marcelo.magallon@grafana.com>
The-9880
approved these changes
Apr 29, 2024
mem
deleted the
use-the-same-logic-for-timeout-validation-in-adhoc-and-regular-checks
branch
The-9880
added a commit
that referenced
this pull request
Apr 30, 2024
* Feature: upgrade k6 to v0.50.0 (#681) * Chore(deps): Bump github.com/prometheus/blackbox_exporter * skip interpolating multihttp variables into the metric names (#683) * proto fields for scripted check enablement (#674) * Switch to using buf to manage protobuf code (#641) * Release v0.23.4 (#685) * Fix: TestTickWithOffset sometimes if offset is 0 (#686) * Chore(deps): Bump the prometheus-go group with 2 updates * Chore(deps): Bump github.com/miekg/dns from 1.1.58 to 1.1.59 * Log configuration at start up (#689) * Feature: automatically set up GOMEMLIMIT (#691) * Terminate agent if capabilities not supported (#684) * Make k6 capability validation nil-safe (#692) * Fix: use uniform timeout validation logic (#693) Signed-off-by: Anant Sharma <anant.sharma@grafana.com>
Closed
The-9880
added a commit
that referenced
this pull request
Apr 30, 2024
* Feature: upgrade k6 to v0.50.0 (#681) * Chore(deps): Bump github.com/prometheus/blackbox_exporter * skip interpolating multihttp variables into the metric names (#683) * proto fields for scripted check enablement (#674) * Switch to using buf to manage protobuf code (#641) * Release v0.23.4 (#685) * Fix: TestTickWithOffset sometimes if offset is 0 (#686) * Chore(deps): Bump the prometheus-go group with 2 updates * Chore(deps): Bump github.com/miekg/dns from 1.1.58 to 1.1.59 * Log configuration at start up (#689) * Feature: automatically set up GOMEMLIMIT (#691) * Terminate agent if capabilities not supported (#684) * Make k6 capability validation nil-safe (#692) * Fix: use uniform timeout validation logic (#693) Signed-off-by: Anant Sharma <anant.sharma@grafana.com>
Closed
The-9880
added a commit
that referenced
this pull request
Apr 30, 2024
* Feature: upgrade k6 to v0.50.0 (#681) * Chore(deps): Bump github.com/prometheus/blackbox_exporter * skip interpolating multihttp variables into the metric names (#683) * proto fields for scripted check enablement (#674) * Switch to using buf to manage protobuf code (#641) * Release v0.23.4 (#685) * Fix: TestTickWithOffset sometimes if offset is 0 (#686) * Chore(deps): Bump the prometheus-go group with 2 updates * Chore(deps): Bump github.com/miekg/dns from 1.1.58 to 1.1.59 * Log configuration at start up (#689) * Feature: automatically set up GOMEMLIMIT (#691) * Terminate agent if capabilities not supported (#684) * Make k6 capability validation nil-safe (#692) * Fix: use uniform timeout validation logic (#693) * k6runner: handle errors reported by http runners * k6runner/test: add test for RunResponse error handling * k6runner: inspect errors and propagate unexpected ones to the probe Signed-off-by: Anant Sharma <anant.sharma@grafana.com>
Merged
mem
pushed a commit
that referenced
this pull request
Apr 30, 2024
* Feature: upgrade k6 to v0.50.0 (#681) * Chore(deps): Bump github.com/prometheus/blackbox_exporter * skip interpolating multihttp variables into the metric names (#683) * proto fields for scripted check enablement (#674) * Switch to using buf to manage protobuf code (#641) * Release v0.23.4 (#685) * Fix: TestTickWithOffset sometimes if offset is 0 (#686) * Chore(deps): Bump the prometheus-go group with 2 updates * Chore(deps): Bump github.com/miekg/dns from 1.1.58 to 1.1.59 * Log configuration at start up (#689) * Feature: automatically set up GOMEMLIMIT (#691) * Terminate agent if capabilities not supported (#684) * Make k6 capability validation nil-safe (#692) * Fix: use uniform timeout validation logic (#693) * k6runner: handle errors reported by http runners * k6runner/test: add test for RunResponse error handling * k6runner: inspect errors and propagate unexpected ones to the probe Signed-off-by: Anant Sharma <anant.sharma@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should be using the same timeout validation logic for adhoc and regular checks.
The downside of this is that adhoc checks with long timeouts might take a long time to run. We can fix this by introducing some observability and figuring out if that's a problem or not.