Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: use uniform timeout validation logic #693

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Fix: use uniform timeout validation logic #693

merged 1 commit into from
Apr 29, 2024

Commits on Apr 29, 2024

  1. Fix: use uniform timeout validation logic 

    We should be using the same timeout validation logic for adhoc and
regular checks.

The downside of this is that adhoc checks with long timeouts might take
a long time to run. We can fix this by introducing some observability
and figuring out if that's a problem or not.

Signed-off-by: Marcelo E. Magallon <marcelo.magallon@grafana.com>
    @mem
    mem committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    4e07dcd View commit details
    Browse the repository at this point in the history