Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the basic stuff to support a browser check type #737

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Add the basic stuff to support a browser check type #737

merged 2 commits into from
Jun 24, 2024

Conversation

mem
Copy link
Contributor

@mem mem commented Jun 19, 2024

  • Add the settings to the proto definitions and generate the corresponding code.
  • Add the fake data for the scraper test.
  • Generate the corresponding accounting data.
  • Scaffold the scraper.

@mem
Add the basic stuff to support a browser check type
18c9d95 
- Add the settings to the proto definitions and generate the
  corresponding code.
- Add the fake data for the scraper test.
- Generate the corresponding accounting data.
- Scaffold the scraper.

Signed-off-by: Marcelo E. Magallon <marcelo.magallon@grafana.com>
@mem mem requested a review from a team as a code owner June 19, 2024 23:33
@mem
Copy link
Contributor Author

mem commented Jun 19, 2024

This is part of https://github.com/grafana/synthetic-monitoring/issues/72

@mem @roobre
Update pkg/pb/synthetic_monitoring/checks_extra.go
c9dd30f 
Co-authored-by: Ro Santalla <roobre@users.noreply.github.com>
@mem mem requested a review from roobre June 20, 2024 21:47
roobre
roobre approved these changes Jun 21, 2024
View reviewed changes
Copy link
Collaborator

@roobre roobre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need a dedicated class to bill browser differently (I'm not sure how that works exactly), but for the time being I think this is the way to go.

@mem mem merged commit 9730c0b into main Jun 24, 2024
4 checks passed
@mem mem deleted the mem/add-browser-check-type branch June 24, 2024 22:58
ka3de added a commit that referenced this pull request Jul 10, 2024
@ka3de
Fix browser check class
15b4165 
Addresses previous TODO comments left in #737 about the correct Check
Class for browser checks. After the introduction of a specific browser
check class in #787 we can address these comments and make browser
checks a class on its own, that is necessary in order to distinguish
telemetry from scripted checks.
@ka3de ka3de mentioned this pull request Jul 10, 2024
Closed
roobre added a commit that referenced this pull request Jul 15, 2024
@roobre
Release v0.25.0
e7731bf 
* Chore(deps): Bump google.golang.org/grpc from 1.63.2 to 1.64.0
* grpc: nolint deprecated grpc options
* Build(deps): Bump the prometheus-go group across 1 directory with 2 updates
* http: rename `promconfig.Header` to `promconfig.ProxyHeader`
* Add the basic stuff to support a browser check type (#737)
* k6runner/test: ensure logs are sent to loki when runner reports user errors
* k6runner: send logs even if metrics are malformed
* Build(deps): Bump github.com/prometheus/common
* Bump k6 version using renovate (#745)
* Dispatch renovate workflow manually (#746)
* Update renovate (#748)
* Update dependency grafana/k6 to v0.52.0 (#749)
* Fix renovate configuration (#751)
* Update github.com/grafana/loki/pkg/push digest to 04bc3a4 (#752)
* Update module github.com/dmarkham/enumer to v1.5.10 (#754)
* Update module github.com/sirupsen/logrus to v1.9.3 (#755)
* Update module github.com/stretchr/testify to v1.9.0 (#759)
* Update dependency grafana/grafana-build-tools to v0.15.0 (#756)
* Correct the listen address to scrape metrics to port 4050. (#743)
* Build(deps): Bump google.golang.org/grpc from 1.64.0 to 1.65.0
* Update module github.com/securego/gosec to v2
* Split and fix renovate config (#767)
* Update ghcr.io/grafana/grafana-build-tools Docker tag to v0.15.1 (#770)
* add validation case for browser (#773)
* Update module gotest.tools/gotestsum to v1.12.0
* Update module go.k6.io/k6 to v0.52.0
* Update golang.org/x/exp digest to 7f521ea
* Update module golang.org/x/net to v0.27.0 (#775)
* Update module github.com/securego/gosec to v2
* Update module gotest.tools/gotestsum to v1.12.0
* Update module github.com/spf13/afero to v1.11.0 (#758)
* Update module github.com/golangci/golangci-lint to v1.59.1
* Update github.com/grafana/loki/pkg/push digest to 6da364e
* Update module github.com/securego/gosec to v2
* Route browser checks to the browser prober (#780)
* Update module google.golang.org/grpc to v1.65.0 (#761)
* ci/renovate: limit gomod digest updates to once every two weeks (#785)
* Update golang.org/x/exp digest to 46b0784 (#781)
* cmd: default to sm-k6 binary
* Dockerfile: copy sm-specific k6 as sm-k6 instead of just k6
* k6runner/test: pass address of expectErrorAs to errors.As
* k6runner: log errors encountered by logfmt parser
* Update github.com/grafana/loki/pkg/push digest to 7c86e65
* Add browser limits and class (#787)
* Update module github.com/prometheus/prometheus to v0.53.1 (#790)
* Report browser check's class as browser (#788)
* Update github.com/grafana/loki/pkg/push digest to 527510d (#793)
* Update github.com/securego/gosec/v2 digest to 4487a0c

Signed-off-by: Ro Santalla <roberto@santalla.io>
@roobre roobre mentioned this pull request Jul 15, 2024
Merged
roobre added a commit that referenced this pull request Jul 15, 2024
@roobre
Release v0.25.0
f193b2e 
* Chore(deps): Bump google.golang.org/grpc from 1.63.2 to 1.64.0
* grpc: nolint deprecated grpc options
* Build(deps): Bump the prometheus-go group across 1 directory with 2 updates
* http: rename `promconfig.Header` to `promconfig.ProxyHeader`
* Add the basic stuff to support a browser check type (#737)
* k6runner/test: ensure logs are sent to loki when runner reports user errors
* k6runner: send logs even if metrics are malformed
* Build(deps): Bump github.com/prometheus/common
* Bump k6 version using renovate (#745)
* Dispatch renovate workflow manually (#746)
* Update renovate (#748)
* Update dependency grafana/k6 to v0.52.0 (#749)
* Fix renovate configuration (#751)
* Update github.com/grafana/loki/pkg/push digest to 04bc3a4 (#752)
* Update module github.com/dmarkham/enumer to v1.5.10 (#754)
* Update module github.com/sirupsen/logrus to v1.9.3 (#755)
* Update module github.com/stretchr/testify to v1.9.0 (#759)
* Update dependency grafana/grafana-build-tools to v0.15.0 (#756)
* Correct the listen address to scrape metrics to port 4050. (#743)
* Build(deps): Bump google.golang.org/grpc from 1.64.0 to 1.65.0
* Update module github.com/securego/gosec to v2
* Split and fix renovate config (#767)
* Update ghcr.io/grafana/grafana-build-tools Docker tag to v0.15.1 (#770)
* add validation case for browser (#773)
* Update module gotest.tools/gotestsum to v1.12.0
* Update module go.k6.io/k6 to v0.52.0
* Update golang.org/x/exp digest to 7f521ea
* Update module golang.org/x/net to v0.27.0 (#775)
* Update module github.com/securego/gosec to v2
* Update module gotest.tools/gotestsum to v1.12.0
* Update module github.com/spf13/afero to v1.11.0 (#758)
* Update module github.com/golangci/golangci-lint to v1.59.1
* Update github.com/grafana/loki/pkg/push digest to 6da364e
* Update module github.com/securego/gosec to v2
* Route browser checks to the browser prober (#780)
* Update module google.golang.org/grpc to v1.65.0 (#761)
* ci/renovate: limit gomod digest updates to once every two weeks (#785)
* Update golang.org/x/exp digest to 46b0784 (#781)
* cmd: default to sm-k6 binary
* Dockerfile: copy sm-specific k6 as sm-k6 instead of just k6
* k6runner/test: pass address of expectErrorAs to errors.As
* k6runner: log errors encountered by logfmt parser
* Update github.com/grafana/loki/pkg/push digest to 7c86e65
* Add browser limits and class (#787)
* Update module github.com/prometheus/prometheus to v0.53.1 (#790)
* Report browser check's class as browser (#788)
* Update github.com/grafana/loki/pkg/push digest to 527510d (#793)
* Update github.com/securego/gosec/v2 digest to 4487a0c

Signed-off-by: Ro Santalla <roberto@santalla.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roobre roobre roobre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mem @roobre