Report browser check's class as browser #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the purpose of having some clarity in the data that is made available to users, report the class of the browser check as "browser", not "scripted". This allows us to segment the data when reporting executions. Signed-off-by: Marcelo E. Magallon <marcelo.magallon@grafana.com>
mem
commented
Jul 9, 2024
|
|
||
| mm = []sm.RegionTelemetry{ | ||
| // 0: this is the expected message for ee[0] -> ee[3] executions | ||
| func getTestDataset(idx int) testData { |
There was a problem hiding this comment.
I ended up doing this because at some point it felt like I was fighting a water balloon: I would squeeze here and it would blow up over there.
This was referenced Jul 10, 2024
Closed
ka3de
approved these changes
Jul 10, 2024
roobre
approved these changes
Jul 10, 2024
roobre
added a commit
that referenced
this pull request
Jul 15, 2024
* Chore(deps): Bump google.golang.org/grpc from 1.63.2 to 1.64.0 * grpc: nolint deprecated grpc options * Build(deps): Bump the prometheus-go group across 1 directory with 2 updates * http: rename `promconfig.Header` to `promconfig.ProxyHeader` * Add the basic stuff to support a browser check type (#737) * k6runner/test: ensure logs are sent to loki when runner reports user errors * k6runner: send logs even if metrics are malformed * Build(deps): Bump github.com/prometheus/common * Bump k6 version using renovate (#745) * Dispatch renovate workflow manually (#746) * Update renovate (#748) * Update dependency grafana/k6 to v0.52.0 (#749) * Fix renovate configuration (#751) * Update github.com/grafana/loki/pkg/push digest to 04bc3a4 (#752) * Update module github.com/dmarkham/enumer to v1.5.10 (#754) * Update module github.com/sirupsen/logrus to v1.9.3 (#755) * Update module github.com/stretchr/testify to v1.9.0 (#759) * Update dependency grafana/grafana-build-tools to v0.15.0 (#756) * Correct the listen address to scrape metrics to port 4050. (#743) * Build(deps): Bump google.golang.org/grpc from 1.64.0 to 1.65.0 * Update module github.com/securego/gosec to v2 * Split and fix renovate config (#767) * Update ghcr.io/grafana/grafana-build-tools Docker tag to v0.15.1 (#770) * add validation case for browser (#773) * Update module gotest.tools/gotestsum to v1.12.0 * Update module go.k6.io/k6 to v0.52.0 * Update golang.org/x/exp digest to 7f521ea * Update module golang.org/x/net to v0.27.0 (#775) * Update module github.com/securego/gosec to v2 * Update module gotest.tools/gotestsum to v1.12.0 * Update module github.com/spf13/afero to v1.11.0 (#758) * Update module github.com/golangci/golangci-lint to v1.59.1 * Update github.com/grafana/loki/pkg/push digest to 6da364e * Update module github.com/securego/gosec to v2 * Route browser checks to the browser prober (#780) * Update module google.golang.org/grpc to v1.65.0 (#761) * ci/renovate: limit gomod digest updates to once every two weeks (#785) * Update golang.org/x/exp digest to 46b0784 (#781) * cmd: default to sm-k6 binary * Dockerfile: copy sm-specific k6 as sm-k6 instead of just k6 * k6runner/test: pass address of expectErrorAs to errors.As * k6runner: log errors encountered by logfmt parser * Update github.com/grafana/loki/pkg/push digest to 7c86e65 * Add browser limits and class (#787) * Update module github.com/prometheus/prometheus to v0.53.1 (#790) * Report browser check's class as browser (#788) * Update github.com/grafana/loki/pkg/push digest to 527510d (#793) * Update github.com/securego/gosec/v2 digest to 4487a0c Signed-off-by: Ro Santalla <roberto@santalla.io>
Merged
roobre
added a commit
that referenced
this pull request
Jul 15, 2024
* Chore(deps): Bump google.golang.org/grpc from 1.63.2 to 1.64.0 * grpc: nolint deprecated grpc options * Build(deps): Bump the prometheus-go group across 1 directory with 2 updates * http: rename `promconfig.Header` to `promconfig.ProxyHeader` * Add the basic stuff to support a browser check type (#737) * k6runner/test: ensure logs are sent to loki when runner reports user errors * k6runner: send logs even if metrics are malformed * Build(deps): Bump github.com/prometheus/common * Bump k6 version using renovate (#745) * Dispatch renovate workflow manually (#746) * Update renovate (#748) * Update dependency grafana/k6 to v0.52.0 (#749) * Fix renovate configuration (#751) * Update github.com/grafana/loki/pkg/push digest to 04bc3a4 (#752) * Update module github.com/dmarkham/enumer to v1.5.10 (#754) * Update module github.com/sirupsen/logrus to v1.9.3 (#755) * Update module github.com/stretchr/testify to v1.9.0 (#759) * Update dependency grafana/grafana-build-tools to v0.15.0 (#756) * Correct the listen address to scrape metrics to port 4050. (#743) * Build(deps): Bump google.golang.org/grpc from 1.64.0 to 1.65.0 * Update module github.com/securego/gosec to v2 * Split and fix renovate config (#767) * Update ghcr.io/grafana/grafana-build-tools Docker tag to v0.15.1 (#770) * add validation case for browser (#773) * Update module gotest.tools/gotestsum to v1.12.0 * Update module go.k6.io/k6 to v0.52.0 * Update golang.org/x/exp digest to 7f521ea * Update module golang.org/x/net to v0.27.0 (#775) * Update module github.com/securego/gosec to v2 * Update module gotest.tools/gotestsum to v1.12.0 * Update module github.com/spf13/afero to v1.11.0 (#758) * Update module github.com/golangci/golangci-lint to v1.59.1 * Update github.com/grafana/loki/pkg/push digest to 6da364e * Update module github.com/securego/gosec to v2 * Route browser checks to the browser prober (#780) * Update module google.golang.org/grpc to v1.65.0 (#761) * ci/renovate: limit gomod digest updates to once every two weeks (#785) * Update golang.org/x/exp digest to 46b0784 (#781) * cmd: default to sm-k6 binary * Dockerfile: copy sm-specific k6 as sm-k6 instead of just k6 * k6runner/test: pass address of expectErrorAs to errors.As * k6runner: log errors encountered by logfmt parser * Update github.com/grafana/loki/pkg/push digest to 7c86e65 * Add browser limits and class (#787) * Update module github.com/prometheus/prometheus to v0.53.1 (#790) * Report browser check's class as browser (#788) * Update github.com/grafana/loki/pkg/push digest to 527510d (#793) * Update github.com/securego/gosec/v2 digest to 4487a0c Signed-off-by: Ro Santalla <roberto@santalla.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the purpose of having some clarity in the data that is made available to users, report the class of the browser check as "browser", not "scripted". This allows us to segment the data when reporting executions.