Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add golangci-lint with default linters #761

Merged
merged 2 commits into from
Sep 20, 2022
Merged

Add golangci-lint with default linters #761

merged 2 commits into from
Sep 20, 2022

Conversation

julienduchesne
Copy link
Member

Just an initial go at fixing some minor code issues.

Some linters (like revive) will find lots of things so I'm starting with an initial basic run

@github-actions
Copy link
Contributor

github-actions bot commented Sep 20, 2022 •
edited
Loading

Benchstat (compared to main):

name              old time/op    new time/op    delta
GetSnippetHash-2    21.0ms ± 3%    21.2ms ± 1%  +1.08%  (p=0.028 n=10+9)

name              old alloc/op   new alloc/op   delta
GetSnippetHash-2    3.86MB ± 0%    3.86MB ± 0%    ~     (p=0.077 n=9+9)

name              old allocs/op  new allocs/op  delta
GetSnippetHash-2     32.3k ± 0%     32.3k ± 0%  +0.01%  (p=0.032 n=9+10)

@julienduchesne
Add golangci-lint with default linters
0ed40f5 
Just an initial go at fixing some minor code issues.

Some linters (like `revive`) will find lots of things so I'm starting with an initial basic run
@julienduchesne julienduchesne force-pushed the julienduchesne/enable-linter branch from 51f3843 to 0ed40f5 Compare September 20, 2022 13:31
@julienduchesne julienduchesne marked this pull request as ready for review September 20, 2022 13:42
@julienduchesne julienduchesne requested review from sh0rez, Duologic and a team and removed request for sh0rez September 20, 2022 13:43
@julienduchesne julienduchesne merged commit ba3386a into main Sep 20, 2022
@julienduchesne julienduchesne deleted the julienduchesne/enable-linter branch September 20, 2022 15:31
julienduchesne added a commit that referenced this pull request Sep 20, 2022
@julienduchesne
More golanci-lint checks
8f0a015 
Active a bunch more linters following #761
This is mostly style checks like remove snake case variables and not starting error messages with an uppercase. This leads to a more consistent codebase
@julienduchesne julienduchesne mentioned this pull request Sep 20, 2022
Merged
julienduchesne added a commit that referenced this pull request Sep 21, 2022
@julienduchesne
More golanci-lint checks (#762)
8cc1e0a 
Active a bunch more linters following #761
This is mostly style checks like remove snake case variables and not starting error messages with an uppercase. This leads to a more consistent codebase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iainlane iainlane iainlane approved these changes

@Duologic Duologic Awaiting requested review from Duologic

@sh0rez sh0rez Awaiting requested review from sh0rez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julienduchesne @iainlane