Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More golangci-lint checks #762

Merged
merged 1 commit into from
Sep 21, 2022
Merged

Conversation

julienduchesne
Copy link
Member

@julienduchesne julienduchesne commented Sep 20, 2022

Activate a bunch more linters following #761
This is mostly style checks like removing snake case variables and not starting error messages with an uppercase. This leads to a more consistent codebase

Active a bunch more linters following #761
This is mostly style checks like remove snake case variables and not starting error messages with an uppercase. This leads to a more consistent codebase
@julienduchesne julienduchesne changed the title More golanci-lint checks More golangci-lint checks Sep 20, 2022
@github-actions
Copy link
Contributor

Benchstat (compared to main):

name              old time/op    new time/op    delta
GetSnippetHash-2    21.6ms ± 4%    22.4ms ± 5%  +3.66%  (p=0.011 n=10+10)

name              old alloc/op   new alloc/op   delta
GetSnippetHash-2    3.85MB ± 0%    3.86MB ± 0%  +0.08%  (p=0.004 n=9+10)

name              old allocs/op  new allocs/op  delta
GetSnippetHash-2     32.3k ± 0%     32.3k ± 0%  +0.02%  (p=0.013 n=8+10)

@julienduchesne julienduchesne marked this pull request as ready for review September 20, 2022 16:01
@julienduchesne julienduchesne requested review from sh0rez, Duologic and a team September 20, 2022 16:01
@julienduchesne julienduchesne merged commit 8cc1e0a into main Sep 21, 2022
@julienduchesne julienduchesne deleted the julienduchesne/more-linters branch September 21, 2022 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants