Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update controller-runtime, controller-gen and other dependencies #1091

Closed
wants to merge 3 commits into from

Conversation

iblancasa
Copy link
Collaborator

Closes #1090

Signed-off-by: Israel Blancas <iblancas@redhat.com>
@iblancasa
Copy link
Collaborator Author

I have to regenerate something...

Signed-off-by: Israel Blancas <iblancas@redhat.com>
Signed-off-by: Israel Blancas <iblancas@redhat.com>
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 28.94737% with 27 lines in your changes missing coverage. Please review.

Project coverage is 67.73%. Comparing base (1fb2623) to head (c1b95b8).

Files with missing lines Patch % Lines
apis/config/v1alpha1/projectconfig_types.go 0.00% 20 Missing ⚠️
cmd/root.go 63.63% 3 Missing and 1 partial ⚠️
controllers/tempo/certrotation_controller.go 0.00% 1 Missing ⚠️
controllers/tempo/tempomonolithic_controller.go 0.00% 1 Missing ⚠️
controllers/tempo/tempostack_controller.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1091      +/-   ##
==========================================
- Coverage   67.91%   67.73%   -0.18%     
==========================================
  Files         110      110              
  Lines        8728     8760      +32     
==========================================
+ Hits         5928     5934       +6     
- Misses       2503     2528      +25     
- Partials      297      298       +1     
Flag Coverage Δ
unittests 67.73% <28.94%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@rubenvp8510
Copy link
Collaborator

rubenvp8510 commented Nov 19, 2024

@iblancasa This PR #1092 also include the version bump WDYT if we close this in favor of the one for the new layout? If we do separate PRs the conflicts will be high and hard to fix

@iblancasa iblancasa closed this Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update controller-runtime library to v0.19.1
3 participants