Migrate to kubebuilder v4 layout #1092
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubenvp8510
force-pushed
the
migrate_kubebuilder_v4
branch
4 times, most recently
from
56c0231
to
0a595ac
Compare
Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com>
Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com>
Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com>
Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com>
Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com>
Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1092 +/- ##
==========================================
- Coverage 67.91% 58.58% -9.34%
==========================================
Files 110 114 +4
Lines 8728 10151 +1423
==========================================
+ Hits 5928 5947 +19
- Misses 2503 3901 +1398
- Partials 297 303 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rubenvp8510
requested review from
andreasgerstmayr,
pavolloffay,
frzifus and
iblancasa
iblancasa
reviewed
Nov 20, 2024
| @@ -45,25 +44,16 @@ func init() { | |||
| //+kubebuilder:scaffold:scheme | |||
| } | |||
|
|
|||
| //var errConfigFileLoading = errors.New("could not read file at path") | |||
Comment on lines
+53
to
54
| return err | ||
| } |
There was a problem hiding this comment.
Can you keep the message here? I think it gives context and help debugging stuff
|
|
||
| // LoadConfig initializes the controller configuration, optionally overriding the defaults | ||
| // from a provided configuration file. | ||
| func LoadConfig(scheme *runtime.Scheme, configFile string) (*configv1alpha1.ProjectConfig, ctrl.Options, error) { |
There was a problem hiding this comment.
Maybe add some tests to the methods from this file?
|
|
||
| var errConfigFileLoading = errors.New("could not read file at path") | ||
|
|
||
| func loadConfigFile(scheme *runtime.Scheme, outConfig *configv1alpha1.ProjectConfig, configFile string) error { |
There was a problem hiding this comment.
Maybe you can move this to options.go
|
Some nits. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.