Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize page.on events #1227

Closed
7 tasks done
Tracked by #1460
ankur22 opened this issue Feb 29, 2024 · 2 comments
Closed
7 tasks done
Tracked by #1460

Generalize page.on events #1227

ankur22 opened this issue Feb 29, 2024 · 2 comments
Assignees
Labels
dx developer experience refactor

Comments

@ankur22
Copy link
Collaborator

ankur22 commented Feb 29, 2024

What

Generalize page.on events architecture.

Why

So that new events can easily be added to the existing code.

Tasks

  1. refactor tests
    inancgumus
  2. refactor
    inancgumus
  3. refactor
    inancgumus
  4. refactor
    inancgumus
  5. dx refactor
    inancgumus
  6. refactor
    inancgumus
@ankur22 ankur22 added feature A new feature playwright Issue relating to Playwright compatibility next Might be eligible for the next planning (not guaranteed!) user request Requested by the community labels Feb 29, 2024
@inancgumus inancgumus changed the title Implement page.on events Generalize page.on events May 6, 2024
@inancgumus
Copy link
Member

I've changed this issue's title to focus on the generalization of page.on as the total work is lengthy. Please revert if you think otherwise.

@inancgumus inancgumus removed the next Might be eligible for the next planning (not guaranteed!) label Jun 20, 2024
@ankur22
Copy link
Collaborator Author

ankur22 commented Oct 4, 2024

During the PR to add page.on('metric') helpful comments were added which identified areas that could be refactored to work with generics:

@ankur22 ankur22 mentioned this issue Oct 4, 2024
3 tasks
@inancgumus inancgumus mentioned this issue Oct 4, 2024
@ankur22 ankur22 assigned ankur22 and unassigned ankur22 Oct 7, 2024
@inancgumus inancgumus self-assigned this Oct 9, 2024
@inancgumus inancgumus added refactor and removed feature A new feature user request Requested by the community playwright Issue relating to Playwright compatibility labels Oct 9, 2024
@inancgumus inancgumus added the dx developer experience label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx developer experience refactor
Projects
None yet
Development

No branches or pull requests

2 participants