This repository has been archived by the owner on Jan 30, 2025. It is now read-only.
Refactor page.on event handling
#1479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inancgumus
force-pushed
the
refactor/page-on-task-in-queue
branch
from
7272ab4 to
3c90197
Compare
inancgumus
force-pushed
the
refactor/page-on-event-handling
branch
from
049c6ad to
2b80331
Compare
We need to read lock first to prevent race conditions while looping over the handlers. Then, we allow each handler to add a nested handler by read unlocking it.
inancgumus
force-pushed
the
refactor/page-on-event-handling
branch
from
2b80331 to
6a294db
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Refactor
page.onevent handling.Why?
#1456 (comment)
Checklist
Related PR(s)/Issue(s)
Updates: #1227