This repository has been archived by the owner on Jan 30, 2025. It is now read-only.
Unify page.on event mappings
#1473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mapped methods are lowercase so that we can test them. They're also used in JavaScript like so.
So that we can use it the mapping test.
JavaScript functions are conventionally lowercase, and since we changed Tag to tag from the Go side, we should also rename this script.
So that we can get rid of the non-conforming metric mapper. This way, we don't have to deal with error handling in other mappers in the test. This provides a uniform way. Also, this is a prior step for the generalization of the page on API.
inancgumus
changed the title
page.on metric event mappingpage.on('metric') event mapping
inancgumus
commented
Oct 9, 2024
inancgumus
changed the title
page.on('metric') event mappingpage.on event mappings
Co-authored-by: Ankur <ankur.agarwal@grafana.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
page.onevent mappings to the existing mappers.Why?
This will be needed when generalizing the
page.onAPI events. To be generalized, all mappers need to be in the same signature. This is a part of the suggestions.Checklist
Related PR(s)/Issue(s)
Updates: #1227