Add predefined network profiles #1098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankur22
changed the title
ankur22
force-pushed
the
add/cpu-throttle
branch
from
b9d470b
to
9849922
Compare
ankur22
force-pushed
the
add/predefined-network-profiles
branch
2 times, most recently
from
0d0a684
to
d78d1b3
Compare
ankur22
force-pushed
the
add/cpu-throttle
branch
from
9849922
to
06ba5e0
Compare
ankur22
force-pushed
the
add/predefined-network-profiles
branch
from
d78d1b3
to
95553a7
Compare
ka3de
reviewed
Nov 13, 2023
inancgumus
previously approved these changes
Nov 13, 2023
ankur22
force-pushed
the
add/cpu-throttle
branch
from
06ba5e0
to
63afdee
Compare
ankur22
force-pushed
the
add/predefined-network-profiles
branch
from
95553a7
to
1ce6756
Compare
ankur22
force-pushed
the
add/cpu-throttle
branch
from
c618da5
to
27cd1ab
Compare
ankur22
dismissed stale reviews from ka3de and inancgumus
The base branch was changed.
ankur22
force-pushed
the
add/predefined-network-profiles
branch
from
9118e77
to
0f67e4a
Compare
This type now feels like it should live closer to where the predefined network profiles have been defined.
These are common network profiles which are used in various chromium based browsers. It feels like it's a safe bet that these will be the most widely used network profiles. We intend to add more once we have a clearer idea of what.
Instead of defining a custom network profile, use the predefined one (slow 3g). This serves as a good example as to how to work with predefined network profiles.
This will be useful when a user may want to disable the network throttling half way through a test.
This was copied from https://stackoverflow.com/questions/48367042/in-chrome-dev-tools-what-is-the-speed-of-each-preset-option-for-network-throttl which outlined what the numbers mean when calculating the download and upload throughputs. We can use this to helps us create our own profiles when we need.
ankur22
force-pushed
the
add/predefined-network-profiles
branch
from
0f67e4a
to
884e4b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adding predefined network profiles
No Throttling,Slow 3GandFast 3G.Why?
These are the most commonly used during frontend testing when throttling network connections.
These could have been defined in the type definitions repo. To make it simpler for our users to work with these network profiles, it's defined in the browser module repo which will make it available for browser module users.
Checklist
Related PR(s)/Issue(s)
Updates #887