Playwright compatibility: Improve valueFromRemoteObject null detection
#1369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inancgumus
force-pushed
the
fix/valueFromRemoteObject-for-null
branch
from
3025d90
to
ca059a1
Compare
Previously, we can't detect a null value:
v, _ := page.GetAttribute("#el", "missing", nil)
assert.Nil(t, nil, v) // v is not nil
Now, `v` will be `nil` instead of "null" as a string. This enables us to
detect `nil` in methods like GetAttribute, TextNode, etc. to tell the
user that what they're looking for does not exist instead of returning
"null" or an empty string.
inancgumus
force-pushed
the
fix/valueFromRemoteObject-for-null
branch
from
ca059a1
to
d6e3ca8
Compare
ankur22
approved these changes
Jun 5, 2024
inancgumus
changed the title
valueFromRemoteObject null detectionvalueFromRemoteObject null detection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Improve
valueFromRemoteObjectnulldetection by returning a Gonilinstead of"null"as a string.Why?
Previously, we couldn't detect a null value:
After this PR,
vwill benilinstead of"null"as a string. This enables us to detectnilin methods likeGetAttribute,TextNode, etc., to tell the user that what they're looking for does not exist instead of returning"null"or an empty string.Checklist