Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON-RPC call reassign_subgraph in graph-node fails if a deployment has been copied #4394

Closed
lutter opened this issue Feb 23, 2023 · 0 comments · Fixed by #4395
Closed

JSON-RPC call reassign_subgraph in graph-node fails if a deployment has been copied #4394

lutter opened this issue Feb 23, 2023 · 0 comments · Fixed by #4395

Comments

@lutter
Copy link
Collaborator

lutter commented Feb 23, 2023 •
edited
Loading

When a deployment has been copied, the IPFS hash does not identify the deployment uniquely any more, and there will be two (or more) deployments with the same hash. graph-node's JSON-RPC reassign_subgraph request fails because a lookup of that IPFS hash returns multiple deployments.

The call handler should be changed so that reassign_subgraph always changes the active copy if there are multiple copies of a deployment.

On the network, this issue causes the indexer-agent to get stuck since it tries to reassign subgraphs
@lutter lutter mentioned this issue Feb 23, 2023
Closed
lutter added a commit that referenced this issue Feb 23, 2023
@lutter
all: Indicate whether to only locate active deployment
bff0b16 
The reassign_subgraph JSON-RPC call will fail if a deployment exists in
multiple shards. To disambiguate that, change the call so that it only
affects the active deployment.

Fixes #4394
@lutter lutter mentioned this issue Feb 23, 2023
Merged
lutter added a commit that referenced this issue Feb 24, 2023
@lutter
all: Indicate whether to only locate active deployment
2b58fb9 
The reassign_subgraph JSON-RPC call will fail if a deployment exists in
multiple shards. To disambiguate that, change the call so that it only
affects the active deployment.

Fixes #4394
lutter added a commit that referenced this issue Feb 24, 2023
@lutter
all: Indicate whether to only locate active deployment
6e5b2dd 
The reassign_subgraph JSON-RPC call will fail if a deployment exists in
multiple shards. To disambiguate that, change the call so that it only
affects the active deployment.

Fixes #4394
@lutter lutter closed this as completed in cc0f2d3 Feb 24, 2023
@AnPiakhota AnPiakhota mentioned this issue Dec 6, 2023
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

all: Indicate whether to only locate active deployment graphprotocol/graph-node
1 participant
@lutter