all: Indicate whether to only locate active deployment #4395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tilacog
reviewed
Feb 23, 2023
core/src/subgraph/registrar.rs
Outdated
| @@ -411,7 +411,7 @@ where | |||
| hash: &DeploymentHash, | |||
| node_id: &NodeId, | |||
| ) -> Result<(), SubgraphRegistrarError> { | |||
| let locations = self.store.locators(hash)?; | |||
| let locations = self.store.locators(hash, true)?; | |||
There was a problem hiding this comment.
We expect this to return a vector with a single DeploymentLocator (the active copy), right?
tilacog
approved these changes
Feb 23, 2023
mangas
reviewed
Feb 24, 2023
graph/src/components/store/traits.rs
Outdated
| /// If `only_active` is `true`, only the locator for the active | ||
| /// deployment will be returned. If it is `false`, locators for all | ||
| /// deployments with this hash will be returned. | ||
| fn locators(&self, hash: &str, only_active: bool) |
There was a problem hiding this comment.
I think we should split this into something like all_locators and active_locators instead of using a flag, when someone is using or reading this function with a bool they need to go read the docs to figure what the bool is used for, when using all/active naming then it's obvious both when writing and when reading the code.
There was a problem hiding this comment.
I just removed the boolean flag and added a fn active_locator to the trait
lutter
force-pushed
the
lutter/reassign-rpc
branch
2 times, most recently
from
2b58fb9 to
6e5b2dd
Compare
mangas
approved these changes
Feb 24, 2023
The reassign_subgraph JSON-RPC call will fail if a deployment exists in multiple shards. To disambiguate that, change the call so that it only affects the active deployment. Fixes #4394
lutter
force-pushed
the
lutter/reassign-rpc
branch
from
9eb6bfd to
3f7fe67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reassign_subgraph JSON-RPC call will fail if a deployment exists in multiple shards. To disambiguate that, change the call so that it only affects the active deployment.
Fixes #4394