Fix: jsonErrorReplacer to use explicit Error type #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enisdenjo
approved these changes
Aug 26, 2024
Thank you! Yes, sometimes you can't depend on a machine, lol |
|
Maybe if |
|
🎉 This PR is included in version 1.22.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the jsonErrorReplacer function to use explicit Error casting, improving type safety and preventing potential errors.
Changes
In the
src/handler.tsfile, thejsonErrorReplacerfunction contains an argumentvalwith a type ofany. However, the function also includes a type checkval instanceof Error, which allows for a safe cast to the Error type. To leverage this type information, we can introduce a type cast using theaskeyword, assigning the casted value to a new variable error. This refinement enables the TypeScript compiler to accurately infer the type of error and eliminates any potential type errors.