Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: jsonErrorReplacer to use explicit Error type #125

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Fix: jsonErrorReplacer to use explicit Error type #125

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -880,10 +880,11 @@ function jsonErrorReplacer(
// GraphQL errors implement their own stringer
!isGraphQLError(val)
) {
const error = val as Error;
return {
// name: val.name, name is included in message
message: val.message,
// stack: val.stack, can leak sensitive details
// name: error.name, name is included in message
message: error.message,
// stack: error.stack, can leak sensitive details
};
}
return val;
Expand Down
Loading