Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for node14 #3855

Merged
merged 1 commit into from
Feb 25, 2023
Merged

Conversation

IvanGoncharov
Copy link
Member

Motivation: technically node14 end of life will happen in two months so we can still support it but it creates problems with #3791 Node14 doesn't support AbortSignal and since we want to allow resolvers to be canceled we need to expose this object through our public API (inside info argument). Potentialy this and all the other issues (e.g. how to test this feature on node14) can be worked around but complicates solution. So I think, it worth to deprecate node14 two months earlier in order to unblock #3791 especially since we still in alpha stage.

Less critical but still significant problem with node14 is that it ships with npm6 which doesn't support default format of the lockfile used by npm9 and this make updating dependencies trickier.

@IvanGoncharov IvanGoncharov added the PR: breaking change 💥 implementation requires increase of "major" version number label Feb 23, 2023
@netlify
Copy link

netlify bot commented Feb 23, 2023

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit da0a0d5
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/63f9e2fbaee0820008fde60d
😎 Deploy Preview https://deploy-preview-3855--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

Hi @IvanGoncharov, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

Motivation: technically node14 end of life will happen in two months so we can still support it but it creates problems with graphql#3791
Node14 doesn't support `AbortSignal` and since we want to allow resolvers to be canceled we need to expose this object through our public API (inside `info` argument).
Potentialy this and all the other issues (e.g. how to test this feature on node14) can be worked around but complicates solution.
So I think, it worth to deprecate node14 two months earlier in order to unblock graphql#3791 especially since we still in alpha stage.

Less critical but still significant problem with node14 is that it ships with npm6 which doesn't support default format of the lockfile
used by npm9 and this make updating dependencies trickier.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: breaking change 💥 implementation requires increase of "major" version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant