Ensure tbot compiles on windows #43877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
hugoShaka
commented
Jul 5, 2024
strideynet
approved these changes
Jul 5, 2024
There was a problem hiding this comment.
Looks good but @timothyb89 should deffo review this as well.
EdwardDowling
approved these changes
Jul 5, 2024
|
You could also add tbot to the build-windows workflow to prevent this from regressing |
timothyb89
approved these changes
Jul 5, 2024
hugoShaka
requested review from
klizhentas,
russjones,
r0mant,
zmb3,
fheinecke,
camscale,
tcsc,
rosstimothy and
codingllama
as code owners
zmb3
approved these changes
Jul 8, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
I struggled to get tbot to compile on windows as io and syscall bits were spread across tbot's codebase. @strideynet or @timothyb89 please take another look as the PR significantly changed since you reviewed it. Cross-compilation now works: # install cross-compiler
brew install mingw-w64
# build for windows
GOOS=windows GOARCH=amd64 make build/tbot -B
GOOS=windows GOARCH=amd64 CGO_ENABLED=1 CC=x86_64-w64-mingw32-gcc CXX=x86_64-w64-mingw32-g++ go build -tags " kustomize_disable_go_plugin_support" -o build/tbot -ldflags '-w -s ' -trimpath -buildmode=pie ./tool/tbot
# build for darwin
make build/tbot -B
GOOS=darwin GOARCH=arm64 go build -tags " kustomize_disable_go_plugin_support" -o build/tbot -ldflags '-w -s -extldflags=-ld_classic' -trimpath ./tool/tbot
# build for linux
GOOS=linux GOARCH=amd64 make build/tbot -B
GOOS=linux GOARCH=amd64 go build -tags " kustomize_disable_go_plugin_support" -o build/tbot -ldflags '-w -s ' -trimpath ./tool/tbot |
timothyb89
approved these changes
Jul 8, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
@hugoShaka See the table below for backport results.
|
hugoShaka
added a commit
that referenced
this pull request
Jul 11, 2024
* Ensure tbot compiles on windows * Restore unix tbot support * fixup! Restore unix tbot support * address feedback * Fix tbot build on windows, use CGO for this OS * Move unix-specific syscalls and file descriptors out of os-agnostic files * fixup! Move unix-specific syscalls and file descriptors out of os-agnostic files * lint
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 12, 2024
* Ensure tbot compiles on windows * Restore unix tbot support * fixup! Restore unix tbot support * address feedback * Fix tbot build on windows, use CGO for this OS * Move unix-specific syscalls and file descriptors out of os-agnostic files * fixup! Move unix-specific syscalls and file descriptors out of os-agnostic files * lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tbot was not compiling on windows, this was not an issue because we never tried to. Now that tctl can run an embedded tbot (
tctl terraform env) we needlib/tbotto compile on windows.This PR splits the fs implementations for 3 OS variants:
This PR potentially breaks compiling tbot on non unix systems that are not windows. However I think this was never a thing to begin with as compilation was very likely broken (non unix systems don't have
*syscall.Stat_t).After this PR tbot should now build on windows, and even be able to write files. However, as it is not able to verify ownership I don't think we want to officially support it yet.
Changelog: Make tbot compilable on Windows.