[v15] Ensure tbot compiles on windows #44070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Ensure tbot compiles on windows * Restore unix tbot support * fixup! Restore unix tbot support * address feedback * Fix tbot build on windows, use CGO for this OS * Move unix-specific syscalls and file descriptors out of os-agnostic files * fixup! Move unix-specific syscalls and file descriptors out of os-agnostic files * lint
hugoShaka
requested review from
klizhentas,
russjones,
r0mant,
zmb3,
fheinecke,
camscale and
tcsc
as code owners
github-actions
bot
requested review from
codingllama,
EdwardDowling,
rosstimothy,
strideynet and
timothyb89
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
1 similar comment
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
zmb3
approved these changes
Jul 11, 2024
timothyb89
approved these changes
Jul 11, 2024
public-teleport-github-review-bot
bot
removed request for
codingllama,
strideynet,
EdwardDowling and
rosstimothy
camscale
added
no-changelog
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of #43877 to
branch/v15because of a Makefile conflict.changelog: Made
tbotcompilable on Windows.