[branch/v16] Invoke signing function for Windows Connect binary #44419
Conversation
build.assets/windows/build.ps1
Outdated
| @@ -473,7 +490,7 @@ function Write-Version-Objects { | |||
| & $GoWinres simply --no-suffix --arch amd64 ` | |||
| --file-description "Teleport tsh command-line client" ` | |||
| --original-filename tsh.exe ` | |||
| --copyright "Copyright (C) $Year Gravitational Inc." ` | |||
| --copyright "Copyright (C) $Year Gravitational, Inc." ` | |||
There was a problem hiding this comment.
Best to run a tag build and then right click and go to properties on tsh.exe in a Windows environment. This version metadata is very picky and I seem to recall something about the comma breaking things.
build.assets/windows/build.ps1
Outdated
| --icon "$TeleportSourceDirectory\e\windowsauth\installer\teleport.ico" ` | ||
| --product-name Teleport ` | ||
| --product-version $TeleportVersion ` | ||
| --file-version $TeleportVersion ` | ||
| --out "$TeleportSourceDirectory\tool\tctl\resource.syso" | ||
|
|
||
| # generate windowsauth version info (note the --admin flag, as the installer must run as admin) | ||
| & $GoWinres simply --no-suffix --arch amd64 --admin ` |
There was a problem hiding this comment.
Why was this removed?! This is necessary in order for the installer to properly request admin permissions.
|
@zmb3 I screwed up my local backport commands and this should now be fixed, with a significantly smaller set of changes. |
|
Looks better but I'm now confused how this fixes anything. All I can see is that |
|
Yep that's pretty much it. Somehow when I did several other backports I managed to include only part of the original PR and it's breaking things due to this attribute. |
|
Having |
public-teleport-github-review-bot
bot
removed the request for review
from ravicious
Backport #41963
changelog: Fixed Teleport Connect binaries not being signed correctly.