Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[branch/v16] Invoke signing function for Windows Connect binary #44419

Merged
merged 3 commits into from
Jul 22, 2024
Merged

[branch/v16] Invoke signing function for Windows Connect binary #44419

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
431448d
Invoke signing function for Windows Connect binary (#41963)
fheinecke Jul 18, 2024
eef2180
revert accidental changes
fheinecke Jul 19, 2024
441de9c
Add support for signing Windows binaries without a destination path (…
fheinecke May 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions build.assets/windows/build.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,13 +275,18 @@ function Invoke-SignBinary {
<#
.SYNOPSIS
Signs the provided binary with the base64-encoded certificate listed in "$WINDOWS_SIGNING_CERT"
.PARAMETER UnsignedBinaryPath
The path to the unsigned binary.
.PARAMETER SignedBinaryPath
The path where the signed binary should be written. If not provided, then the signed binary will
be written to a temporary path, and then moved to the unsigned binary path.
#>
[CmdletBinding()]
param(
[Parameter(Mandatory)]
[string] $UnsignedBinaryPath,

[Parameter(Mandatory)]
[Parameter()]
[string] $SignedBinaryPath
)

Expand Down Expand Up @@ -343,7 +348,7 @@ function Build-Tsh {
$UnsignedBinaryPath = "$BuildDirectory\unsigned-$BinaryName"
go build -tags piv -trimpath -ldflags "-s -w" -o "$UnsignedBinaryPath" "$TeleportSourceDirectory\tool\tsh"
if ($LastExitCode -ne 0) {
exit $LastExitCode
exit $LastExitCode
}
Write-Host "::endgroup::"

Expand Down Expand Up @@ -376,7 +381,7 @@ function Build-Tctl {
$UnsignedBinaryPath = "$BuildDirectory\unsigned-$BinaryName"
go build -tags piv -trimpath -ldflags "-s -w" -o "$UnsignedBinaryPath" "$TeleportSourceDirectory\tool\tctl"
if ($LastExitCode -ne 0) {
exit $LastExitCode
exit $LastExitCode
}
Write-Host "::endgroup::"

Expand Down
Loading