-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX] Be able to use spark execution engine with spark reuse flag #3541
Conversation
👷 Deploy request for niobium-lead-7998 pending review. 🔨 Explore the source changes: afc1e1d |
Thanks so much for opening this PR, @fep2! We will review and be in touch in the next couple of days. In the meantime, it appears that some tests are failing. Would you mind taking a look and seeing if you can resolve? Please let me know if you need any help with that. |
Hi @fep2 - just wanted to check in, would you be up for seeing which tests are failing and fixing them? Thanks! |
@talagluck I found the issue for why it breaks last week, I need to update some of the class in order for the test to pass. I'm making progress those path need to be updated, and that should hopefully fix the test. |
@talagluck I was able to fix the test woo hoo! |
Now some are failing boo, but they don't seem to be related to the MR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing - thanks so much for following up, and thanks for the contribution! LGTM!
Changes proposed in this pull request:
adding force_reuse_spark_context to Execution Engine Schema
My code follows the Great Expectations style guide
I have performed a self-review of my own code
I have added unit tests where applicable and made sure that new and existing tests are passing.
I have run any local integration tests and made sure that nothing is broken.
Thank you for submitting!